Hi As discussed on IRC a little recently, and in issue: http://sigrok.org/bugzilla/show_bug.cgi?id=868
First, please consider pulling into sigrok-cli support for multiple protocol decoders and dropping the -S option [1] By updating sigrok-cli first, it gains proper support for stacking decoders based on the IDs returned by libsigrokdecode, instead of it having implicit knowledge of the ids. Branch at: https://github.com/karlp/sigrok-cli/tree/pulls/multipro Commits: + 0b9982b drop -S stack option + f999f28 Support multiple protocol decoder stacks + d9de37a include decoder instance id in normal outputs [2] + 27105be valgrind: Clear more unfreed memory issues Subsequently, Please consider pulling into libsigrokdecode support for multiple instances of a decoder in a session. Branch available at: https://github.com/karlp/libsigrokdecode/tree/pulls/inst-ids Commits: + 8dd7fde valgrind: safely iterate lists + fe20e5e valgrind: free channels + 3b722ff support adding multiple instances of a decoder + fc841fb look up instances by id in the full stack Without these changes, sigrok-cli won't actualy be able to _use_ the support for multiple -P options, but it works quite happily on single decoder ("legacy") command lines just as before. Note: the valgrind commits are independent, and can be omitted if desired, but were easy to clean as I was working in this area. Contentious issues: [1] Dropping -S outright, or I can rework it to make -S simply an undocumented no-op, if CLI compatibility is critically important. [2] This changes the CLI output to include the decoder instance id. Again, how critically important is the CLI output? I would presume that it's not intended for scraping anyway, the decoders and output files are for those purposes. Sincerely, Karl Palsson
signature.asc
Description: OpenPGP Digital Signature
------------------------------------------------------------------------------
_______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
