On Dienstag, 23. Oktober 2018 23:21:43 CEST Guido Trentalancia wrote:
> At the moment only the maximum number of frames to be acquired can be
> configured for the Hameg/Rohde&Schwarz HMO mixed-signal oscilloscope
> series driver (hameg-hmo).
> 
> This patch adds support to configure the number of samples to acquire
> in both analog and digital (logic) mode.

I have some doubts this works correctly in all cases. When a buffer has been 
filled on the device side and is requested by libsigrok, the whole buffer has 
to be fetched. There is no SCPI method to request e.g. only the first 50k 
samples, AFAIK. If you stop reading after 50k samples and the device has 
prepared 500k samples, the remainder will be returned as response to the next 
command.

--- 
> The second version (v2) of this patch introduced the support for 16
> digital (logic) channels for the following oscilloscope models: HMO3032,
> HMO3042, HMO3052 and HMO3522 (previously only 8 digital channels were
> supported, i.e. only 1 POD).

This change is not related to the original patch and does not fit the
subject. It should go into a separate patch.
 
> Also, such version had been tested not only with 8 digital (logic)
> channels (i.e. with 1 POD) as in the first version, but also with 16
> digital (logic) channels (i.e. with 2 PODs).
> 
---
> Finally, the previous version (v2) took care of removing an invalid
> product model (HMO2522) and added a missing product model (HMO3522),
> thus extending the number of supported oscilloscope models.

This change is also not related to the original patch and does not fit the
subject. It should go into another patch.

 
> This third version (v3) fixes a bug in the previous (v2) version that
> was causing a segmentation fault when trying to acquire digital data
> using the limit on the number of frames instead of the limit on the
> number of samples.

Kind regards,

Stefan

-- 
Stefan Brüns  /  Bergstraße 21  /  52062 Aachen
home: +49 241 53809034     mobile: +49 151 50412019

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to