Hello. Il giorno mer, 24/10/2018 alle 14.53 +0200, Stefan Brüns ha scritto: > On Dienstag, 23. Oktober 2018 23:21:43 CEST Guido Trentalancia wrote: > > At the moment only the maximum number of frames to be acquired can > > be > > configured for the Hameg/Rohde&Schwarz HMO mixed-signal > > oscilloscope > > series driver (hameg-hmo). > > > > This patch adds support to configure the number of samples to > > acquire > > in both analog and digital (logic) mode. > > I have some doubts this works correctly in all cases. When a buffer > has been > filled on the device side and is requested by libsigrok, the whole > buffer has > to be fetched. There is no SCPI method to request e.g. only the first > 50k > samples, AFAIK. If you stop reading after 50k samples and the device > has > prepared 500k samples, the remainder will be returned as response to > the next > command.
I have tested this patch using sigrok-cli and it does not seem to suffer the side-effect that you describe. Therefore, I suppose it works correctly and as intended in all cases. More precisely, in the situation that you describe, the buffer is truncated at 50k samples (instead of 500k samples) and when the next command is issued a new buffer is used, which therefore does not contain "the remainder of the previous data" but instead it contains new data. Unless, you provide a specific way to reproduce the side-effect that you described above, there is no way to confirm that the patch is affected by a bug and needs to be fixed. > --- > > The second version (v2) of this patch introduced the support for 16 > > digital (logic) channels for the following oscilloscope models: > > HMO3032, > > HMO3042, HMO3052 and HMO3522 (previously only 8 digital channels > > were > > supported, i.e. only 1 POD). > > This change is not related to the original patch and does not fit the > subject. It should go into a separate patch. This seems to me like a minor issue, but I will now create separate patches for such functionality. > > Also, such version had been tested not only with 8 digital (logic) > > channels (i.e. with 1 POD) as in the first version, but also with > > 16 > > digital (logic) channels (i.e. with 2 PODs). > > > > --- > > Finally, the previous version (v2) took care of removing an invalid > > product model (HMO2522) and added a missing product model > > (HMO3522), > > thus extending the number of supported oscilloscope models. > > This change is also not related to the original patch and does not > fit the > subject. It should go into another patch. This seems to me like a minor issue, but I will now create separate patches for such functionality. > > This third version (v3) fixes a bug in the previous (v2) version > > that > > was causing a segmentation fault when trying to acquire digital > > data > > using the limit on the number of frames instead of the limit on the > > number of samples. > > Kind regards, > > Stefan Patch v4 will follow shortly along with two new separate patches tackling the other two issues (16 digital channels on HMO3XX2 and invalid/missing product models). Regards, Guido _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
