On Thu, 08/11/2018 at 15.09 +0000, Brüns, Stefan wrote: > On Donnerstag, 8. November 2018 00:00:21 CET Guido Trentalancia > wrote: > > On Wed, 07/11/2018 at 22.31 +0000, Brüns, Stefan wrote: > > > On Mittwoch, 7. November 2018 22:35:16 CET Guido Trentalancia > > > wrote: > > > > Update the default serial port options for Rohde&Schwarz and > > > > Hameg mixed-signal oscilloscope devices connected through USB. > > > > > > > > Also, remove misplaced and unused serial port configuration > > > > option from the hameg-hmo driver. > > > > > > > > This patch complements the following commit: > > > > > > > > fa3d104f17966dd66664f5ee1cccd05856a7e312 > > > > > > > > in terms of updating the USB PIDs for new devices (HMO series). > > > > > > > > However, in order to make full use of such default serial > > > > port options for USB connections and to avoid data corruption > > > > or even worse connection problems, the following patch is also > > > > required: > > > > > > > > Use appropriate default serial port options for USB connections > > > > > > > > This second version (v2) of the patch simply fixes a comment > > > > describing the device models. > > > > > > Can you please verify your changes are correct? > > > > For sure, they provide a great improvement to the previous state ! > > > > 100% correct data can only be provided by Rohde&Schwarz. I do not > > work > > for Rohde&Schwarz, but instead I am an end-user of their products, > > so > > there is some web search and guess work involved. > > > > > The 0x0118 ID is used by the HMO1002, which was never distributed > > > under the > > > Hameg brand. > > > > This does not seem to be true, according to some online documents > > !! > > > > Have a look at these, for example: > > > > https://www.eetimes.com/document.asp?doc_id=1323020 > > > > http://www.hameg.it/desk_hmo1002.htm > > > > https://octopart.com/hmo1002-hameg-47300984 > > > > https://www.merazet.pl/produkt/oscyloskop-cyfrowy-hameg-hmo1002-507 > > 0100 > > -mhz-2-kanaly/ > > > > Google will help you find many more... > > Just look at the pictures, it shows the R&S logo. The HMO1002 was > brought to > market a significant time after Hameg has been acquired by R&S. It > uses the > R&S USB vendor ID exclusively.
What you say, doesn't make sense to me ! The R&S USB vendor ID applies only to the (optional) interface. So, one user might be using an oscilloscope branded Hameg and be using an interface bought later on and therefore branded by Rohde&Schwarz ! The comment is intended to clarify the history of the HMO series ! The HMO series has been designed by Hameg, and the proof is that the product code begins with "HM", while products designed by Rohde&Schwarz have a product code which begins with "R". Also, this is a serious bug fix patch which along with the other companion patch avoids DATA CORRUPTION !! A meaningless source code comment is not the ultimate purpose of this patch. > > > The other two IDs are not tied to specific devices, but to the > > > HO720/HO730 > > > interface boards. These can be used with devices from the HMO, > > > HMS(- > > > X) and > > > HMF/HMP series. > > > > The HMS-X / HMF / HMP series does not appear to be supported by > > sigrok > > (only the HMO), therefore I have not included it here because it > > would > > just cause confusion. > > > > Just a few minutes ago, before you replied to my post, I have > > updated > > the official Linux usb.ids database: > > > > https://usb-ids.gowdy.us/read/UD/0aad > > > > As you can see, in such update, the new data is reported "HMF / HMP > > / > > HMS-X / HMO series Oscilloscopes": all of this is intentional (see > > above) ! > > > > Do not forget the HO732 interface. But it's pointless to mention > > the > > interface names: they would just cause confusion, because you need > > the > > manual to check the interface name, while everyone knows his or her > > oscilloscope series and it's written on the device ! So, I am > > pretty > > sure, it's far better to mention the oscilloscope series here and > > leave > > the interface names for the oscilloscope manuals. > > The interface card can be changed. Its name is shown in the devices > setup > menu. It is written on the back of the device. I do not agree with anything that you wrote in this thread about this patch. I am not going to amend this patch because I believe it is correct and provides the best information available. I reject the changes that you are proposing to this patch. If you think that you can provide an improved version of the code, you are free to submit your own patch to the mailing list or whatever other way, but you are entirely on your own and you don't have my support for the changes that you are proposing here. I hope this helps. Regards, Guido _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
