Thanks for your reply. I didn't realise there was more than one place for pull requests (I still don't know of any others), and so I didn't think there would be any confusion. Sorry about that. In any case, this is the specific pull request:
https://github.com/sigrokproject/libsigrokdecode/pull/7 I understand that people can be busy. I'm busy too! We're all busy. It's just that I thought that six months would have been plenty of time to at least get *some* response. Even if it was just to tell me I'm doing it wrong. How am I supposed to know if I haven't supplied all the required info if someone doesn't tell me? I should point out that I'm not looking for help. I'm really very happy with sigrok, pulseview and that I've been able to fix the supplied decoders so that they worked. I just wanted to contribute my fixes back and maybe supply a few new decoders of my own. I've written seven so far. I sort of wanted to know if it was going to be worth the effort to clean up my code, collect some sample data and submit it all... Thanks again, Andrew On Sat, 25 May 2019 at 00:47, Gerhard Sittig <gerhard.sit...@gmx.net> wrote: > On Thu, 2019-05-23 at 10:39 +0800, Andrew Gregory wrote: > > > > Hi, > > > > I submitted a pull request for the Modbus decoder many months > > ago last December. > > > > It's been completely ignored. > > > > I'm guessing it's because I haven't posted here? > > Maintainers usually are rather busy. Sending another ping after > some time has passed is OK and can be helpful. There is no > intent or the slightest amount of evil in it when something > doesn't happen, usually it's just a lack of available resources. > > It would have been even more helpful if you could provide a > reference to the very pull request, and not expect readers to > guess what you may refer to, or have to look it up themselves. :) > That might be another reason for falling off the radar. Help > those people you want to receive help from ... > > Was the sample data part of your pull request? Lack of example > data to demonstrate an issue, or to use a new or changed decoder, > can also prevent or slow down review and acceptance of a > submission. If you have an interest (and the permission) to > submit the data to the public code base, can you provide a commit > to the dumps repo as well? The preferred method is to push to > some public git repo, and just mention the URL(s) here in the > mailing list or in the chat (IRC). "Full"/"official" pull > requests are usually not required, and are not the project's > preferred means of submission (haven't been in the past), and > might go unnoticed at times (can't tell for sure, I'm not a > maintainer, and neither a github user, and github is just a > mirror of the project not its main infrastructure). > > > virtually yours > Gerhard Sittig > -- > If you don't understand or are scared by any of the above > ask your parents or an adult to help you. > > > _______________________________________________ > sigrok-devel mailing list > sigrok-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/sigrok-devel > -- Andrew
_______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
