On Thu, 2019-05-30 at 17:10 +0800, Andrew Gregory wrote:
>
> Thanks for your reply.
>
> I didn't realise there was more than one place for pull requests (I still
> don't know of any others), and so I didn't think there would be any
> confusion. Sorry about that. In any case, this is the specific pull request:
>
> https://github.com/sigrokproject/libsigrokdecode/pull/7
Thank you for that reference. I'm ignorant about modbus but
others may be able to say something on the subject. Once they
have learned that there is an issue.
> I understand that people can be busy. I'm busy too! We're all busy. It's
> just that I thought that six months would have been plenty of time to at
> least get *some* response. Even if it was just to tell me I'm doing it
> wrong. How am I supposed to know if I haven't supplied all the required
> info if someone doesn't tell me?
You miss the point. Or easily get misled when you start from an
unmet assumption. Ranting while you wait in combination with
waiting even more doesn't necessarily help. Let's see.
You _assume_ that somebody has seen the pull request. I tried to
tell you that this need not be the case. Neither github nor
"official" pull requests are the project's preferred method of
submission. While it's one of the possible ways, it *may* go
unnoticed, or need an additional / parallel trigger. There is
nothing evil about it. Just something to be aware of.
And you _assume_ that others _must_ respond to something that
they haven't seen. Which is hardly possible once you think about
it. How is somebody who's not aware of your attempt supposed to
tell you that he's not aware of it? Hmm ...
You have been waiting for some time. So? No amount of waiting
will change that initial situation. Your request went unnoticed,
you didn't send a ping, nor have you tried other channels. How
is waiting much longer going to change the fact that the attempt
went unnoticed? Instead of waiting, you might as well have tried
to ping somebody or bump the issue, check or re-check the sources
of information that are available to you (and everybody else).
You do have a copy of the source tree with the doc files in it.
You do have access to the project's official site. Don't you?
Just don't accuse others when they don't meet your _assumption_,
at times the assumption may be wrong to begin with.
The same reasoning that you claim for your situation (how are you
supposed to know?) should be acceptable to you when you consider
other people's situation (how are _they_ supposed to know?). The
point is that nobody actively ignored you, or refused to tell how
the project can learn about your contribution. You did get a
response once somebody became aware of your request. Right?
virtually yours
Gerhard Sittig
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
