On Sat, 2019-10-12 at 20:13 +0200, Benedikt Otto wrote:
>
> Thank you very much for the constructive criticism. That is the first
> time that I contribute to such a project.
>
> So far I think I fixed all the issues you mentioned. The repositories
> can be found at:
>
> https://github.com/BenediktO/libsigrokdecode.git
>
> https://github.com/BenediktO/sigrok-test.git
>
> https://github.com/BenediktO/sigrok-dumps.git

Ran a quick test, looked at the PD output with the three files
that you provided. Looks nice.

Can you move the *.sr files under the display/ subdirectory, and
adjust the test configuration of course? And check the README, it
appears to have an incomplete sentence in it.

This could be it. Let's see how the maintainer likes your
submission, or what others can suggest to improve usability.


virtually yours
Gerhard Sittig
--
     If you don't understand or are scared by any of the above
             ask your parents or an adult to help you.


_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to