Hi, On Wed, Nov 06, 2019 at 11:03:09AM +0100, BenediktO wrote: > i just wanted to asked whether the decoder will be included into > libsigrokdecode? I have some more decoders in the pipeline and wanted to > wait until my first one has passed.
Looks good, merged with a few additional minor fixes, thanks a lot! - Squashed-in all fixup commits into one initial commit. - Fixed a few more whitespace/consistency/cosmetics/typos etc. - Please use ' instead of " for all strings in PD (for consistency). - Dropped a few unnecessary comments/docstrings. - pinsToHex -> pins_to_hex - Renamed hd44780-shiftCursor.sr -> hd44780-shiftcursor.sr - Renamed annotation/row to 'Decoded digit(s)', minor clarity improvement I've also grabbed (and partially fixed/adapted) the sigrok-dumps and sigrok-test files, thanks! Grabbed the hd44780 sigrok-dumps files as well already (but not yet the PD). I'm assuming you might still be working on that one? Please also use ' instead of " for that, don't use CamelCase in filenames and methods (e.g. handleSetCGRAMAddress -> handle_set_cgram_address), etc. Please feel free to drop by in the #sigrok IRC channel (Freenode) for more "live" discussions and feedback. Cheers, Uwe. -- http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
