> Is it intended that potential sp_flush() errors get ignored? > (Assuming that DEBUG() is silent in regular applications. And at > most only results in output but won't affect the return code.)
Yes, to avoid regressions. That shows I rate an error there as 'not critical'. I have no strong opinion, though, so can be convinced otherwise. > > Notice that sigrok grew support for several types of serial > communication. Libserialport is one of them, but no longer is the > only one (HID and BT got implemented, network support and others > could get added). Given that libserialport is used in other > projects outside of the sigrok environment, is it worth adjusting > both the libsp open routine as well as libsigrok's common serial > abstraction layer? I am not sure what you mean exactly here, however I think it is generally a good idea to flush buffers when opening a serial port. This is why I think libserialport is a good place. Again, I am open for discussion.
signature.asc
Description: PGP signature
_______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
