Hello Gerhard, thanks for the replies.
On 06/06/2020 12:36, Gerhard Sittig wrote: > On Fri, 2020-06-05 at 18:18 +0200, Christian Mauderer wrote: >> >> I recently got my hands on a Siglent SDS2104X Plus. [ ... ] >> >> Is there some guide or some hints (like notes for porting an older >> Siglent model) that I could use as a starting point to find out what the >> values mean and determine the right values for my scope? > > Usually you'd get the vendor's programming guide for those SCPI > speaking devices. Then compare more recent models' capabilities > to the existing implementation, whether the same set of > instructions can be kept, or new instructions were introduced and > are required to use the newer device's features. Check the > vendor's download area for programming guides, or programming > related chapters in the user manual. > Currently the guide is a bit short on SCPI. They currently have only published a guide for IVI (which basically is just an abstraction). I hoped that the SCPI is similar enough to other Siglent systems that the commands would work and that I can guess the ones that don't. >> @@ -196,6 +197,8 @@ static const struct siglent_sds_series >> supported_series[] = { >> { 50, 1 }, { 500, 100000 }, 14, 8, 14000363}, >> [SDS2000X] = {VENDOR(SIGLENT), "SDS2000X", SPO_MODEL, >> { 50, 1 }, { 500, 100000 }, 14, 8, 14000363}, >> + [SDS2000XP] = {VENDOR(SIGLENT), "SDS2000X Plus", SPO_MODEL, >> + { 50, 1 }, { 500, 100000 }, 14, 8, 14000363}, >> }; >> >> #define SERIES(x) &supported_series[x] > > The specific question of what the supported_series[] table items' > fields mean -- just lookup the the item's data type declaration > (here: struct siglent_sds_series). Your diff's context (the > hunk's caption) shows it already. Get an editor that's capable of > navigating source code, if you don't have one yet. Otherwise > you'd be stuck with mere text search, which is possible but more > tedious. I had already a short look at the structure definitions when adding this but some haven't been clear without some further analysis. Therefore I hoped that I would reach someone via the mailing list who has experience with Siglent devices and maybe still has some notes from an earlier port. That would be a better starting point. Analyzing the code without that was my second best option after that. Best regards Christian > > > virtually yours > Gerhard Sittig > -- > If you don't understand or are scared by any of the above > ask your parents or an adult to help you. > > > _______________________________________________ > sigrok-devel mailing list > sigrok-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/sigrok-devel > _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel