Hello Marcel,
thanks for your answer. It's great that I reached you with the mail.
On 19/06/2020 08:16, marchelh wrote:
> Hi Christian,
>
> I'm the author of the current implementation of the Siglent device
> driver. So maybe I can help finding the issue, also I have a almost
> direct path to Siglent engineering, and I'm able to ask direct questions
> when I have problems. I didn't read the complete message back but what I
> understand is that the device does not responde with the correct
> identification? Or does some functionality not work?
The device identifies itself with "SDS2000X Plus". I attached the patch
from my first mail again. With that patch I get some data but after some
samples (between half and two thirds of the data on the scope screen) I
only get a bit of noise and Sigrok hangs.
> If the device
> identification string is not recognized, than probably adding the device
> specific string in the list should work, however, it is possible that
> some of the properties that get set in this area need to be set for the
> 2000 Plus. I will have a look this weekend if I can find, based on the
> spec sheet, if there are any properties that need attention.
I assume that one of the first problems is to get the values for the
fields in the structures right. The big problems are
- max_timebase in struct siglent_sds
- min_vdiv in struct siglent_sds
- min_timebase in siglent_sds_model
I'm not sure why these fields are arrays with two values each and I
haven't started reading the code yet to find that out.
>
> Kind regards,
> Marcel.
>
> P.S. The Siglent devices have some quirks that some responces are slow,
> specially the older series. Als due to program memory limitations, not
> all advertised functions are available at API level. I have made some
> notes on that on the compatibility sheet of SigRok.
Noted. From what I've seen the SDS2000X seemed quite fast. I haven't had
a really slow operation or response yet. But I haven't checked too much
on the network interface yet.
Best regards
Christian
>
>
>
> -------- Oorspronkelijk bericht --------
> Van: Gerhard Sittig <gerhard.sit...@gmx.net>
> Datum: 07-06-2020 22:15 (GMT+01:00)
> Aan: sigrok-devel@lists.sourceforge.net
> Onderwerp: Re: [sigrok-devel] Siglent SDS2000X Plus series
>
> On Sun, 2020-06-07 at 16:40 +0200, Christian Mauderer wrote:
>>
>> I had already a short look at the structure definitions when adding this
>> but some haven't been clear without some further analysis. Therefore I
>> hoped that I would reach someone via the mailing list who has experience
>> with Siglent devices and maybe still has some notes from an earlier
>> port. That would be a better starting point. Analyzing the code without
>> that was my second best option after that.
>
> Take my words with a grain of salt. And there are more than five
> people on the mailing list AFAIK. :) Let's see what others can
> say. Perhaps the author of the current Siglent SDS support is
> around as well. May just take a few days to respond perhaps.
>
>
> virtually yours
> Gerhard Sittig
> --
> If you don't understand or are scared by any of the above
> ask your parents or an adult to help you.
>
>
> _______________________________________________
> sigrok-devel mailing list
> sigrok-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/sigrok-devel
>
>
> _______________________________________________
> sigrok-devel mailing list
> sigrok-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/sigrok-devel
>
From c828908fb86623ee87e774fc4c243372d8b88208 Mon Sep 17 00:00:00 2001
From: Christian Mauderer <o...@c-mauderer.de>
Date: Fri, 5 Jun 2020 18:09:04 +0200
Subject: [PATCH] FIXME: Add some guesswork for SDS2104X+.
---
src/hardware/siglent-sds/api.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/hardware/siglent-sds/api.c b/src/hardware/siglent-sds/api.c
index 172c8af2..7793e785 100644
--- a/src/hardware/siglent-sds/api.c
+++ b/src/hardware/siglent-sds/api.c
@@ -171,6 +171,7 @@ enum series {
SDS1000XP,
SDS1000XE,
SDS2000X,
+ SDS2000XP,
};
/* short name, full name */
@@ -196,6 +197,8 @@ static const struct siglent_sds_series supported_series[] =
{
{ 50, 1 }, { 500, 100000 }, 14, 8, 14000363},
[SDS2000X] = {VENDOR(SIGLENT), "SDS2000X", SPO_MODEL,
{ 50, 1 }, { 500, 100000 }, 14, 8, 14000363},
+ [SDS2000XP] = {VENDOR(SIGLENT), "SDS2000X Plus", SPO_MODEL,
+ { 50, 1 }, { 500, 100000 }, 14, 8, 14000363},
};
#define SERIES(x) &supported_series[x]
@@ -227,6 +230,7 @@ static const struct siglent_sds_model supported_models[] = {
{ SERIES(SDS2000X), "SDS2204X", { 2, 1000000000 }, 4, FALSE, 0 },
{ SERIES(SDS2000X), "SDS2302X", { 2, 1000000000 }, 2, FALSE, 0 },
{ SERIES(SDS2000X), "SDS2304X", { 2, 1000000000 }, 4, FALSE, 0 },
+ { SERIES(SDS2000XP), "SDS2104X Plus", { 2, 1000000000 }, 4, TRUE, 16 },
};
static struct sr_dev_driver siglent_sds_driver_info;
--
2.26.2
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
