Hello Michael,
Thanks for your contribution! Did you see
https://sigrok.org/wiki/Protocol_decoder_HOWTO#Submitting_your_decoder ?
It would be great to at least have some samples files so we can catch future
regressions. Also, do you have documentation available? It would be great to
have a wiki page for this protocol with at least some documentation as it's
pretty rare, it seems, and I couldn't find a description about it.
That said, I would like to see an updated version of the decoder because of two
issues:
1) "tags = ['IC', 'IR']" should read "tags = ['Embedded/industrial',
'Networking']"
2) "self.wait({'skip': 16})" depends on the sample rate, which will vary for
every setup. Please check
https://sigrok.org/wiki/Protocol_decoder_API/Queries#Sample_skipping_conditions
on how to make this dependent on the supplied sample rate so that the PD works
for everyone.
Regards
-Soeren
On Mon, 2020-09-28 at 08:28 +0200, Michael Stapelberg wrote:
> Please consider merging the attached patch for libsigrokdecode.
>
> Thank you!
> _______________________________________________
> sigrok-devel mailing list
> sigrok-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/sigrok-devel
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
