On Sun, 2021-01-24 at 19:15 +0100, Helge Kruse wrote:
>
> I have recently fixed driver bugs for the Kingst LA2016 driver.
> I have created a pull request for you to merge.
>
> https://github.com/sigrokproject/libsigrok/pull/112
Can you fixup the issues in that series? Bring the commit
messages in line with the project's usual style. Fixup comment
style. Use the common helper for the trigger packet (if you
happen to change that aspect anyway). Separate the logically
different aspects into individual commits. Help those who are
supposed to review and pick up your submission. Thank you!
Who else had a look at these changes, or even tested it for
proper operation? Would be nice to increase coverage. The pain
that you went through was the result of the original submitter's
"works for me" approach, picking a non-portable approach in the
first place. And if there was a review, it missed this issue.
Would be good to get more eyes on such stuff, and more hands
helping out.
virtually yours
Gerhard Sittig
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
