On Sun, 2021-03-07 at 11:31 +0000, Kevin Grant wrote: > > Hello, > > I edited the Sigrok wiki in the last few days to add additional > information about the LA2016 logic analyser. > > https://sigrok.org/wiki/Kingst_LA2016 > > I also marked the device as unsupported (being worked on) because > the driver has problems, not just on windows (as Helge K. pointed > out) but on all platforms.
Is the basic operation fundamentally broken, or are just not all of the product's features available while the device _can_ be used to get captures and inspect or process the waveforms? In the former case I'd agree to "not supported", in the latter I would not. This has not been seen by the way that the wiki page's device state got reverted to "not supported" just because of the presence of a bug in the implementation. Hence my surprise. > It is using the FPGA control registers incorrectly and will not give > expected results in a lot of use cases, e.g. triggered acquisitions. > > Someone re-edited the wiki to again mark the device as supported and > I will leave that in place of course, although I disagree with it. That someone is me, as you can see in the page history. And I only started editing after letting your changes settle, and after checking several times whether I can reach you in the chat, and couldn't. The most pressing reason for editing the page is that you lost or dropped the important USB info resource link. And it would be nice if you'd spell the project's name correctly. The above information on what's not working was not available on the wiki page. All I could see is a rather generic statement along the lines of "something doesn't work, won't tell which that'd be, but the device is not supported". That's when I had to assume that it's just another echo of Helge's interesting idea that the device would not be supported at all because its driver hasn't shipped yet with a release. Or that his platform would not be supported by design while the reason was mere non-portable programming. Which can be fixed, just needs to be done. Properly. If you (Kevin, Helge, and maybe others) strongly feel that the device page should discuss the level of support, then I invite you to do put the information there. Add a section on the driver status, list missing features or spots of incomplete support, etc. So that users can tell whether _their_ use case is covered or isn't. But the wiki has no concept of several shades of green. That's when I felt that "supported" is appropriate given that the device is usable. That's the information that I had at hand at this time. > I sent an experimental patch to Helge K. and Ray M. a week or > so ago but haven't had any feedback yet. Coincidentally last week I tried to address those unresolved feedback issues which Helge would not address, and nobody else stepped up to make it happen or help make it happen. Unfortunately I don't have access to the hardware, so I could not test anything that I wrote. Would be nice if you and others could check this version, which then could go mainline when it's operational. See git://repo.or.cz/libsigrok/gsi.git kingst-la2016-v1-msg or https://repo.or.cz/libsigrok/gsi.git/shortlog/refs/heads/kingst-la2016-v1-msg The driver source code suffers from a few more issues (format strings, diagnostics style, choice of data types, unfortunate dependencies between distant code paths, magic incantations due to lack of a protocol spec), but again without access to the hardware I could not test anything in a useful manner. And some of these issues are next to impossible to address with these closed devices. That's when I just went for the low hanging fruit now. In addition these more intrusive changes would interfere with your work on extending the feature set. So the cleanup needs to be done later. virtually yours Gerhard Sittig -- If you don't understand or are scared by any of the above ask your parents or an adult to help you. _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
