On Tue, 2022-09-13 at 10:30 +0200, Georg Hofmann wrote:
>
> There is a little return code check issue in the korad driver.
> I have made a little pull request for it.
>
> Please review and merge: https://github.com/sigrokproject/libsigrok/pull/195
I took it in a slightly different form. Checking for "below OK"
was unexpected. Have checked for "negative retcode" instead for
consistency (see also the read call near the send check). Have
extended the commit message, so that readers get more details on
the cause for the failure and its fix. That is important if
others want to check drivers which they care about whether they
suffer from similar issues.
Your submission was taken, thank you for providing it.
virtually yours
Gerhard Sittig
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
