No, the patch is no more needed. Your device should work without it. Can you test the latest git version?
Regards, Georg ----- Original Message ----- From: "Christopher Obbard" <ch...@64studio.com> To: "duc" <duc_...@gmx.net> Cc: sigrok-devel@lists.sourceforge.net Sent: Tuesday, September 20, 2022 9:52:17 AM Subject: Re: [sigrok-devel] Request to merge fix for broken korad-kaxxxxp driver Hi, On the subject of the korad driver, I have written https://github.com/sigrokproject/libsigrok/pull/188 to add the model I own. Is it still relevant to be merged or should it be dropped ? Thanks Christopher Obbard On Tue, 20 Sept 2022 at 08:44, Georg Hofmann <duc_...@gmx.net> wrote: > > Hi, > Thanks for your quick correction. No problem to drop my patch, it was only > a quick fix to get my device working. I also think that the version should > not be a required part in the device identification! > > Anyway, I have just compiled and tested git head and it's working find with > my device (KD3005D V6.6). > > Thank you very match for all your work, it's really a great project! > > Regards, > Georg > > ----- Original Message ----- > From: "Gerhard Sittig" <gerhard.sit...@gmx.net> > To: sigrok-devel@lists.sourceforge.net > Sent: Saturday, September 17, 2022 2:56:41 PM > Subject: Re: [sigrok-devel] Request to merge fix for broken korad-kaxxxxp > driver > > On Fri, 2022-09-16 at 11:17 +0200, Georg Hofmann wrote: > > > > I have another pull request > > (https://github.com/sigrokproject/libsigrok/pull/196) > > which fixes not recognized devices by the korad-kaxxxxp driver. Currently > > a device is not recognized each time the device version changes. I have > > added another > > stage in the scan process where the version is excluded. > > That approach of yours would have weakened the version > information check (would not check for 'V', would not check for > digits and periods, would not check for exhaustively covering of > all input text). But most of all it would not work for those > devices which lack whitespace separation of response fields. > > That's why I took a different route. And because your submission > and my approach were done around the same time, so I could not > take yours after I started a more thorough generic approach. The > series is a little longer, to simplify review and help readers > see what's happening. > > https://sigrok.org/gitaction/libsigrok.git/1776a19..68321f7 > > > A bugzilla report is opened for this issue: #1500. > > Seems it's more like 1800. > https://sigrok.org/bugzilla/show_bug.cgi?id=1800 > > > A plea to all: > > Can users of Korad PSUs and clones please run as many tests as > they can? Firmware versions should no longer be an issue. The > libsigrok 1776a1976bfa..68321f73b924 commit series passes local > synthetic tests for previously supported response texts. But only > feedback from users who own the hardware can reliably verify the > driver's proper operation. > > > virtually yours > Gerhard Sittig > -- > If you don't understand or are scared by any of the above > ask your parents or an adult to help you. > > > _______________________________________________ > sigrok-devel mailing list > sigrok-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/sigrok-devel > > > _______________________________________________ > sigrok-devel mailing list > sigrok-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/sigrok-devel _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
