I'm going to ask this again... Can we please merge this simple fix?
https://github.com/sigrokproject/pulseview/pull/50 On Wed, Sep 21, 2022 at 9:47 AM Paul Kasemir <paul.kase...@gmail.com> wrote: > Can we please merge this simple fix? > > https://github.com/sigrokproject/pulseview/pull/50 > > On Wed, Sep 14, 2022 at 10:13 AM Paul Kasemir <paul.kase...@gmail.com> > wrote: > >> Hi, >> >> Can we merge this simple patch from >> https://github.com/sigrokproject/pulseview/pull/50. Without it my >> windows PulseView cross build is failing. >> >> ======================================== >> From e808b2ffdac8e0ec8bf02ec807190a158555a301 Mon Sep 17 00:00:00 2001 >> From: Paul Kasemir <paul.kase...@gmail.com> >> Date: Tue, 30 Aug 2022 12:32:49 -0600 >> Subject: [PATCH] Include <memory> so we don't get error at compile time. >> >> Example build failure: >> In file included from >> /home/paul/sigrok-util/cross-compile/mingw/build_release_64/pulseview/pv/data/segment.cpp:21: >> >> /home/paul/sigrok-util/cross-compile/mingw/build_release_64/pulseview/pv/data/segment.hpp:130:14: >> error: 'shared_ptr' in namespace 'std' does not name a template type >> 130 | typedef std::shared_ptr<pv::data::Segment> SharedPtrToSegment; >> | ^~~~~~~~~~ >> >> /home/paul/sigrok-util/cross-compile/mingw/build_release_64/pulseview/pv/data/segment.hpp:32:1: >> note: 'std::shared_ptr' is defined in header '<memory>'; did you forget to >> '#include <memory>'? >> 31 | #include <QObject> >> +++ |+#include <memory> >> 32 | >> --- >> pv/data/segment.hpp | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/pv/data/segment.hpp b/pv/data/segment.hpp >> index 66085faf..f4601d04 100644 >> --- a/pv/data/segment.hpp >> +++ b/pv/data/segment.hpp >> @@ -24,6 +24,7 @@ >> #include "pv/util.hpp" >> >> #include <atomic> >> +#include <memory> >> #include <mutex> >> #include <thread> >> #include <deque> >> -- >> 2.37.3 >> ======================================== >> >> -- >> Engineering Power - A glowing pool of excellence. >> Lets take a swim. >> > > > -- > Engineering Power - A glowing pool of excellence. > Lets take a swim. > -- Engineering Power - A glowing pool of excellence. Lets take a swim.
_______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
