On 27.10.2023 10:52, Helge Kruse wrote:
Hello Pavel,
I find the build with MSYS2 very interesting. I would like to try it
here, please share.
Just one line:
--- cut ---
CMakeLists.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index ec86073..e7b9251 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -649,6 +649,8 @@ if(WIN32)
list(APPEND PULSEVIEW_LINK_LIBS Qt6::QWindowsIntegrationPlugin)
list(APPEND PULSEVIEW_LINK_LIBS ${QT6ALL_LDFLAGS})
endif()
+ # Temporary workaround, linkage on MSYS2 fails without it.
+ list(APPEND PULSEVIEW_LINK_LIBS -lsigc-2.0)
endif()
if(ENABLE_STACKTRACE)
--- cut ---
Also make sure that your glibmm is really-really up to date (release
-2); there was an issue, fixed by
https://github.com/msys2/MINGW-packages/pull/18961
I believe the fact that libsigrok still pulls in DLLs has very similar
origin. glib headers on Windows have explicit dllimport attributes; and
they cause generating references to __imp_FUNC instead of just FUNC,
sucking in DLLs. We probably need some -D's for libsigrok to bypass
those. I am not looking at it, lower priority for me. I suspect that MXE
build simply doesn't build any Windows stuff as DLLs at all, hence
everything is static with no options, so no problem.
Hope this sheds some light if you want to look at it yourself.
The "Save" problem might be related to the change in bool
StoreSession::start() introduced with commit 292b6ebc. The variable
start_time is now a not initialized DateTime struct instead of a TimeVal.
I know; and it has recently been fixed by
105ecffd86f20a153ab32769a54134e3ad859a09 . But there's more to that.
With demo device it works fine, but when i try save a capture made by my
Arduino Nano (using OLS driver), i get "Unexpected unit size, discarding
logic data." error.
It happens inside zip_append_queue(); buff->unit_size equals to 1,
and "unit_size" of the data being appended is 4. The capture indeed only
has one live channel; the rest (total of 6) are grounded so they're
flatlined at zero. So "1" makes sense and "4" is taken from i don't know
where. Investigation in progress. I'll post a patch when find something.
Or ask questions.
Kind regards.
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
