Damian Krzeminski wrote: > M. Ranganathan wrote: >> On Wed, Aug 20, 2008 at 3:08 PM, Damian Krzeminski <[EMAIL PROTECTED]> wrote: >>> M. Ranganathan wrote: >>>> Attached (includes test case modifications). >>>> >>>> Thanks >>>> >>>> >>> I am getting test errors after applying the patch. >>> >>> [junit] TEST >>> org.sipfoundry.sipxconfig.admin.dialplan.sbc.SbcDeviceManagerImplTestIntegration >>> FAILED >>> >>> > > [...] > >> Hello, >> >> That test is no longer valid as sipxbridge uses sipxrelay and hence >> does not have a port range of its own. >> >> Ranga >> >> > > Well - the test itself is valid > (SbcDeviceManagerImplTestIntegration.testSaveErrorMaxAllowed) > > It's just that after applying the patch storeSbcDevice does not work > anymore. (At the risk of stating the obvious: it's good thing that test > caught it, you would not be able to save sipXbridge configuration if I just > applied the patch) > > Someone needs to look at checkForRTPPortRangeOverlap and see how it needs > to be changed. I would think that since SbcBridge does not have its own > port range it can be safely removed, right? > > And - there is nearly an exact copy of the same function in > NatTraversalManagerImpl, which tells me we should have more tests failing > not just one ;-) > > Any volunteers to clean it up? > > Damian >
I tried to fix it myself. Ranga, Mircea and others interested in NAT traversal and sipXbridge: please check if I got it right. Thanks. http://sipxecs.sipfoundry.org/ViewVC/sipXecs?view=rev&rev=13255 D. _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
