Someone needs to look at checkForRTPPortRangeOverlap and see how it needs
to be changed. I would think that since SbcBridge does not have its own
port range it can be safely removed, right?
And - there is nearly an exact copy of the same function in
NatTraversalManagerImpl, which tells me we should have more tests failing
not just one ;-)
Any volunteers to clean it up?
Damian
I am sorry - I should have offered volunteer for this clean but...
somehow I missed this discussion thread yesterday :(.
I tried to fix it myself. Ranga, Mircea and others interested in NAT
traversal and sipXbridge: please check if I got it right. Thanks.
http://sipxecs.sipfoundry.org/ViewVC/sipXecs?view=rev&rev=13255
D.
Thanks Damian for cleaning this up - You got it right .
In addition, I only cleaned the .properties files removing the obsolete
error messages.
Also, I changed the previous attached tests patch for XCF-2636 - I added
only one test in NatTraversalManagerImplTestIntegration - that verifies
that start port range is lower than end port range.
All these changes are in TestsAndClean.patch file - attached in XCF-2636
issue.
Please review - thanks
Mircea
_______________________________________________
sipx-dev mailing list
[email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
