> On Fri, 2008-12-05 at 19:01 -0600, Arjun Nair (JIRA) wrote: > > [ > > > http://track.sipfoundry.org/browse/XECS-1694?page=com.atlassian.jira.p > > lugin.system.issuetabpanels:all-tabpanel ] > > > > Arjun Nair updated XECS-1694: > > ----------------------------- > > > > Attachment: reg_event_gruu_path_support.diff > > > > Patch Attached.. > > > > This adds support for both gruu and path headers in the reg > event info > > send by sipXregistrar, and the subsequent parsing of that > info by the > > Resource List Server > > > > Details: http://list.sipfoundry.org/archive/sipx-dev/msg15104.html > > A few comments on the patch: > > --- a/sipXpbx/sipXrls/src/ContactSet.cpp > > A few more comments would be helpful, as you've got a lot of > logic packed into a fairly small number of lines of code. > > + TiXmlNode* pub_gruu_node = > + contact_element->FirstChild("gr:pub-gruu");
Good point. I suggest we leave it like that pending the outcome of the TinyXML thread you just started on the mailing list. > > Unfortunately, the composer of the reg event XML is allowed > to choose any prefix it wants for the namespace containing > the pub-gruu element. So this match won't work unless we > know the notifier is going to use the prefix "gr". (This is > a general problem with TinyXML, and we may no longer be able > to dodge it.) > > + // default to sip uri scheme > + tmp.setScheme(Url::SipUrlScheme); > > This code sets the URI scheme of the purported GRUU URI to be > "sip" if it is not "sip" or "sips". But I can't see how that > could work -- consider if the URI was an "http" URI. > Instead, if the scheme is not good, the GRUU should be ignored. I had missed that when I did the code review. Thank you for pointing that out. I'll add that to my to-do list. _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
