Dale Worley wrote:
> A few comments on the patch:
>
> --- a/sipXpbx/sipXrls/src/ContactSet.cpp
>
> A few more comments would be helpful, as you've got a lot of logic
> packed into a fairly small number of lines of code.
Right, I will add in comments to outline whats going on.
>
> + TiXmlNode* pub_gruu_node =
> contact_element->FirstChild("gr:pub-gruu");
>
> Unfortunately, the composer of the reg event XML is allowed to choose
> any prefix it wants for the namespace containing the pub-gruu
> element. So this match won't work unless we know the notifier is
> going to use the prefix "gr". (This is a general problem with
> TinyXML, and we may no longer be able to dodge it.)
>
> + // default to sip uri scheme
> + tmp.setScheme(Url::SipUrlScheme);
>
> This code sets the URI scheme of the purported GRUU URI to be "sip" if
> it is not "sip" or "sips". But I can't see how that could work --
> consider if the URI was an "http" URI. Instead, if the scheme is not
> good, the GRUU should be ignored.
>
ah yes, my bad, this would have been the sensible thing to do here..
Thanks for the comments!
Arjun
_______________________________________________
sipx-dev mailing list
[email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
