Alberto wrote: > Damian Krzeminski ha scritto: >> Thanks. I fixed and updated couple of things in your patch. Please retest >> it. It's attached here: >> http://track.sipfoundry.org/browse/XX-5475 >> > Thanks Damian, I made some other changes to complete what I had in mind > and attached the new patch to the issue. I split the SnomPhone class in > parts. Don't know if this might cause issues, but I feel it's simpler to > manage it.
That makes sense. > > It's hard to say this patch address the BLF thing on Snoms. I will > explain better what we can get out of it in the issue itself. OK - I just needed an issue to track the work. If you feel a different issue might be better for it just create one. >> I would like you to review all the changes to expected-snom-360.xml. They >> should corresponds to the changes in the settings that you made. >> >> If you want to provide more detailed description for the commit (I only can >> say BLF + some parameters changed ;-) just add it as a comment to the issue. >> > You're are absolutely right! I just didn't bother cause I wasn't > finished with the update. Thanks! >> Are you debugging tests? Or are you debugging running application. If you >> are debugging tests - you will not really see Spring injections. Spring IOC >> would only work in integration or DB tests and only for Spring beans (not >> for phones or objects loaded from DB). >> In tests we usually inject mocks or dummy objects into tested classes. >> That's one of the advantages of using IoC (such as Spring): it makes >> testing easy. Please have a look at the updated patch. >> > Yes I was debugging tests. Now I know why it was null. Thanks for making > the changes to the test itself. I really understand a very little of > Mocks at the moment. >> Nope. You did great. The only thing is sipXconfig uses m_ convention for >> private fields (checkstyle complained about it). >> > Without knowing the reason I picked up the convention. Than, cause my > object was null, I followed other paths ... and forgot about it. >> Not using EDE is fine: it might be an overkill if you are just working on >> one plug-in. But please make sure your Eclipse is configured to use Unix >> lien endings. Eclipse is usually pretty good about it: I think that by >> default it keeps the line endings that are already in the file. But in your >> patch there were many LFCR endings. >> > I double checked line endings, but in some cases I see in your patch > it's a matter of substituting tabs with spaces. Is that done > automatically in some way like for the m_ convention checking? > XML files default to CRLF right? Not sure what's the default, but please try to set it up to have unix line endings for all fiels. > The biggest trouble I see in using Eclipse in windows is that checking > out a single project i loose the path that make the build.xml aware of > its dependency. I tried to download all files referenced, but it's a > long way to go ... sipXcommons and sipXconfig are only 2 projects that you need to build plug-ins. And you only need to build sipXcommons once. Maybe you should try EDE after all... Maybe when you tackle next SNOM firmware update ;-) >> >> I am not sure. You probably need to add 2 settings and use conditionals. >> Use different names but the same ProfileName. And of course different >> values... >> > I made it using the model label. Don't know if this is the best way to > do it, but at least it works. > see SnomLineDefaults.getEventListSubscription() > > I'll be happy to review your changes but your patch does not apply. And the parts that do apply make me suspicios - did you mean to remove line.properties or types.xml? Please check if you can apply the patch yourself. If not, and if you cannot think about what went wrong, just zip your entire plugins/snom directory (skip hidden .svn dirs) and I'll try to figure out what's going on. D. _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
