Alberto wrote: > Damian Krzeminski ha scritto: >> >> OK - I just needed an issue to track the work. If you feel a different >> issue might be better for it just create one. >> > Damian you did very well. I just wrote that to manifest my disillusion > in the way Snoms handle the RLS uri. >>> >>> I double checked line endings, but in some cases I see in your patch >>> it's a matter of substituting tabs with spaces. Is that done >>> automatically in some way like for the m_ convention checking? >>> XML files default to CRLF right? >>> >> >> Not sure what's the default, but please try to set it up to have unix line >> endings for all fiels. >> > All XML files I see in neoconf and snom plug-in seems to use CRLF. > Eclipse does already a good job, it won't change line endings, nor add a > single CRLF in a file that use the unix convention. It will use the > system convention for new files, but in that case I converted all new > files, that I just recently added, to the unix style. >>> The biggest trouble I see in using Eclipse in windows is that checking >>> out a single project i loose the path that make the build.xml aware of >>> its dependency. I tried to download all files referenced, but it's a >>> long way to go ... >>> >> >> sipXcommons and sipXconfig are only 2 projects that you need to build >> plug-ins. And you only need to build sipXcommons once. >> Maybe you should try EDE after all... >> Maybe when you tackle next SNOM firmware update ;-) >> > That's impossible ;-) ... should be too quick ... I already have the > next patch ready! But I need some changes that will need some discussion. >>>> I am not sure. You probably need to add 2 settings and use conditionals. >>>> Use different names but the same ProfileName. And of course different >>>> values... >>>> >>> I made it using the model label. Don't know if this is the best way to >>> do it, but at least it works. >>> see SnomLineDefaults.getEventListSubscription() >>>
I changed it: one now needs to declare 'blf' feature in model definition (.beans.xml). That's consistent with how plugins should handle optional features for models. And it can be easily used to add remove conditional settings if needed. >> I'll be happy to review your changes but your patch does not apply. And the >> parts that do apply make me suspicios - did you mean to remove >> line.properties or types.xml? >> > You're right, my mistake. I copied files with your changes within > eclipse between two different projects. Subversive marked the files as > "new (Replaced)" discarding the references to the repository. I was > fooled by the fact I could see the differences in the Team Synchronizing > Perspective. Sorry for the inconvenience. > Patch applied without any problems this time. I made several changes in Velocity template. Have a look let me know if I broke something (if I did add/modify the unit test - I don't have a phone so as long as unit tests are OK I am assuming the template is good). > I just uploaded a new fixed patch in the issue "0002-SNOM-plugin-updates > - fixed.patch". I wanted to delete the bad patch > "0002-SNOM-plugin-updates.patch.patch" but I could not. > It's in mainline now: http://code.sipfoundry.org/changelog/sipXecs/?cs=16948 Thanks a lot and I am looking forward to new contributions. Damian _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
