Peter Fowler wrote:
 


From: [email protected] [mailto:[email protected]] On Behalf Of Cristi Starasciuc
Sent: Friday, January 29, 2010 8:47 AM
To: [email protected]
Subject: [sipX-dev] Regarding Mailbox preferences - active greeting in sipXconfig / sipXIvr (XX-6702)

Hi,

Regarding an older issue: http://track.sipfoundry.org/browse/XX-6702 - Changing greeting type via IVR wipes out IMAP information in mailboxprefs.xml

It was decided that sipXconfig would not generate mailboxprefs.xml anymore and move email/imap information in validusers.xml.

Damian commited a change for this issue in late October 2009, but left the issue open with a comment that "sipXconfig/sipXivr still need to exchange information about voicemail prompt".

I have decided (and it was agreed by Damian) to create a sipXconfig REST interface that would get/set the active greeting. Right now in sipXconfig the activegreeting is kept as a user setting and I imagined sipXivr would use this REST to get/set the activegreeting
(basically, it gets/sets the user setting in sipXconfig).

However there's already a sipxIvr REST interface that does this on IVR side.

Now I'm a bit confused.

Do we really need this REST interface in sipXconfig? Or should sipXconfig just call sipXivr's REST to get/set the active greeting (get for displaying in UI, set for propagating the change to IVR). I see one problem here: if the IVR REST call fails for one reason or another, we risk having inconsistent values for the active greeting.

The original sipXconfig proposal was to provide a REST interface for sipXivr to use whenever it wants to deal with active greeting (probably whenever it reads validusers.xml - which leads me to another question: why isn't the active greeting written in validusers.xml).

Any clarification on this issue would be extremely helpful.


Thanks,
Ciuc 
 
I'm confused as well. There are two comments in XX-6702:
   - sipXconfig does not generate mailboxprefs.xml any more (Damian)
   - sipXconfig/sipXivr still need to exchange information about the voicemail greeting (Damien)
 
As well Woof added a REST API in sipXivr to get/set the active greeting setting but there are no
comments around that change.
 
So its not clear which component is meant to "own" mailboxprefs.xml when it comes to updates. 
If we had a common class that both sipXconfig and sipXivr used to read/write the file  then this wouldn't
be a problem since that class would "own" the data representation. But we don't. 
 
Comments ..?? 
 
Peter   
The way I see it, after some hot debates around here:

mailboxprefs. xml is owned by sipXivr. SipXconfig should write it *through* sipXivr's REST interface.

But: as the wiki says (http://sipx-wiki.calivia.com/index.php/SipXivr%27s_RESTful_api): Requests are currently unauthenticated and not https protected, but they are only accepted from the "localhost" or "local IP address".

What if IVR is installed on another host in a distributed environment. How would sipXconfig access that REST? I know, (and correct me if I'm wrong) that right now sipXIvr is installed on the same machine as sipXconfig, but can we take this for granted? In the future this might change, causing a lot of headaches when that happens.

I strongly believe that (as with other configuration stuff) sipXconfig should expose active greeting related actions through REST and IVR should consume it.
This way, there will be just one entity holding the config and one using it (of course anyone can use it).

Regards,
Ciuc

_______________________________________________
sipx-dev mailing list [email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
sipXecs IP PBX -- http://www.sipfoundry.org/

Reply via email to