Hi,

Regarding the recent Ciscospa plugin commits -

  http://code.sipfoundry.org/changelog/sipXecs/?cs=18316
  http://code.sipfoundry.org/changelog/sipXecs/?cs=18315

It is always a good idea to run "ant precommit" before committing the code 
changes. It runs all of sipXconfig units tests, many of which are not a part of 
"make check". The unit tests in the plugin seem broken, so it breaks ant 
precommit. It should be fixed or commented out as, as it will hold up designer 
testing.

Secondly, it isn't good practice to commit the "Makefile.in" files as they may 
break the build.

Arjun
_______________________________________________
sipx-dev mailing list [email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
sipXecs IP PBX -- http://www.sipfoundry.org/

Reply via email to