Hi Paul, I removed 'Makefile.in'. Would it be possible you can active the code, then I can ask community start test with this.
I try to fix test code here, but if you could also help with this, it would be much appreciated. Thanks, Sen -----Original Message----- From: MOSSMAN, PAUL (PAUL) [mailto:[email protected]] Sent: Monday, March 22, 2010 1:59 AM To: Nair, Arjun (Arjun); [email protected] Cc: [email protected] Subject: RE: [sipX-dev] Ciscospa plugin commit Arjun wrote: > Regarding the recent Ciscospa plugin commits - > > http://code.sipfoundry.org/changelog/sipXecs/?cs=18316 > http://code.sipfoundry.org/changelog/sipXecs/?cs=18315 > > It is always a good idea to run "ant precommit" before committing the > code changes. It runs all of sipXconfig units tests, many of which are > not a part of "make check". The unit tests in the plugin seem broken, > so it breaks ant precommit. > It should be fixed or commented out as, as it will hold up designer > testing. Sorry about that folks. I told Sen to go ahead commit all his code under the new ciscospa dir, but not higher, knowing that it would not break the build. I didn't realize it could break ant precommit. Thanks George for commenting the tests out. > Secondly, it isn't good practice to commit the "Makefile.in" > files as they may break the build. Sen, could you remove these? Thanks. -Paul [email protected] _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
