Hi,
I just noticed that the LDAP authenticator:
ConfigurableLdapAuthenticationProvider throws an ugly exception when
the manager is empty (ldap is not configured)
java.lang.IllegalArgumentException: Manager user name cannot be empty or null.
at org.springframework.util.Assert.hasLength(Assert.java:136)
at
org.acegisecurity.ldap.DefaultInitialDirContextFactory.setManagerDn(DefaultInitialDirContextFactory.java:293)
at
org.sipfoundry.sipxconfig.security.ConfigurableLdapAuthenticationProvider.getDirFactory(ConfigurableLdapAuthenticationProvider.java:130)
I discovered this problem when I did reset the database and tried to
connect with superadmin
1. I think we should make an additional check in
ConfigurableLdapAuthenticationProvider - supports method, to verify if
there is a LDAP server configured for the sistem (making a DB query,
to see if the manager is empty or not). If there is no LDAP server
configured, this method should always return false
2. Also I think that LDAP Only and LDAP and PIN options selection
should not be permitted when there is no LDAP server configured (show
the user some error messages).
Any opinion is welcomed
_______________________________________________
sipx-dev mailing list [email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
sipXecs IP PBX -- http://www.sipfoundry.org/
