On Wed, Jul 21, 2010 at 4:19 AM, Mircea Carasel <[email protected]> wrote: > I just noticed that the LDAP authenticator: > ConfigurableLdapAuthenticationProvider throws an ugly exception when > the manager is empty (ldap is not configured)
ugh, sorry, i was being sloppy, thanks for fix that > 1. I think we should make an additional check in > ConfigurableLdapAuthenticationProvider - supports method, to verify if > there is a LDAP server configured for the sistem (making a DB query, > to see if the manager is empty or not). If there is no LDAP server > configured, this method should always return false I think it lazily gets a copy of the connection parameters and then gets a notification if there has been a change to it and then go gets a new one. Therefore it should always have a fresh copy of the connection parameters w/o have to make a db call on each authentication. > 2. Also I think that LDAP Only and LDAP and PIN options selection > should not be permitted when there is no LDAP server configured (show > the user some error messages). Bigger question: can the user "unconfigure" ldap? Should the ldap connection page have a "delete" button. If so, then you can not even show the settings or import tab if the connection settings are "unconfigured". _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
