--CGDBiGfvSTbxKZlW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hey all,
As I was looking through the SystemImager::Server class (which weighs in now
at over a kloc) it seemed to me that we should look at seperating this
module into functional modules for different tasks.
The functions that make sense to me, though opinions will differ on this,
are as follows:
SystemImager::InstallScript - those functions used to generate the
autoinstall script.
SystemImager::Disk - those functions used to generate the disk portion of
the autoinstall script (as it is a hefty ammount of work by itself).
SYstemImager::Clients - those functions used to generate client definitions
(I'm not sure if this has been broken out of the current addclients
program).
SystemImager::Image - those function used to manipulat image definitions
(like adding image definitions to and from the rsyncd files)
Each of these modules should have clear entry points:
i.e.
SystemImager::Image::create_image($name, $location, ...);
SystemImager::InstallScript::generate_script($name, $image, $arch);
etc.
As the code is still in flux right now, this would be the right time to do
such a change. I also believe this would make it much easier to add
additional non Intel platform support, as only small sections (like the
Disk.pm) would need to be platform specific (and hence keep lots of if($arch
eq ...) out of the code.
What do people think about this idea?
-Sean
--=20
_______________________________________________________________________
=09
Sean Dague [EMAIL PROTECTED] http://dague.net
There is no silver bullet. Plus, werewolves make better neighbors than
zombies, and they tend to keep the vampire population down.
_______________________________________________________________________
--CGDBiGfvSTbxKZlW
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE9UYUpSamXem9TdyYRAjA7AKCLzs/0NdscHfjU73S6Pf4dIf+qWQCgpLEH
8lL/VoCz6attKm4e5oI8KmU=
=eygk
-----END PGP SIGNATURE-----
--CGDBiGfvSTbxKZlW--
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Sisuite-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/sisuite-devel
