Good. I agree with this patch for now and I think we could clean the dir
also if no post-install script are defined, since the variables.txt file
is always present there (see the following patch)...

But in the future when we'll have the firstboot scripts maybe some file
from /tmp/post-install dir could be used also by the firstboot
scripts... in this scenario I think we should preserve the dir (maybe
some interesting info in variables.txt can be useful also during the
first boot).

-Andrea

Index: initrd_source/skel/etc/init.d/functions
===================================================================
--- initrd_source/skel/etc/init.d/functions     (revision 3297)
+++ initrd_source/skel/etc/init.d/functions     (working copy)
@@ -1190,6 +1190,9 @@
         else
             logmsg "No post-install scripts found."
         fi
+
+        # Clean up post-install script directory.
+        rm -rf /a/tmp/post-install/ || shellout
     fi
 }
 #

Bernard Li wrote:

>> Should we ensure that all the post-install scripts were executed
>> correctly before we nuke the directory?
>>
>> Cheers,
>>
>> Bernard


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Sisuite-devel mailing list
Sisuite-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sisuite-devel

Reply via email to