Thus spake Bernard Li ([EMAIL PROTECTED]):
Should we ensure that all the post-install scripts were executed correctly
before we nuke the directory?
If they don't execute correctly, then the "|| shellout" will catch it.
Cheers,
Bernard
________________________________
From: Brian Elliott Finley on behalf of Brian Elliott Finley
Sent: Wed 14/12/2005 23:26
To: Bernard Li
Cc: sisuite-devel@lists.sourceforge.net
Subject: Re: [Sisuite-devel] Cleanup for post-install dir in client's /tmp ?
Much better. :-)
Commit.
And no, you don't need to exit out of the chroot -- you're not in a
chroot at that point.
Thus spake Bernard Li ([EMAIL PROTECTED]):
:-)
Okay, how does this look?
Index: functions
===================================================================
--- functions (revision 3295)
+++ functions (working copy)
@@ -1187,6 +1187,8 @@
chroot /a/ /tmp/post-install/$POST_INSTALL_SCRIPT ||
shellout
fi
done
+
+ rm -rf /a/tmp/post-install/ || shellout
else
logmsg "No post-install scripts found."
fi
I'm not sure if I need to exit from the chroot?
Cheers,
Bernard
________________________________
From: Brian Elliott Finley on behalf of Brian Elliott Finley
Sent: Wed 14/12/2005 22:20
To: Bernard Li
Cc: sisuite-devel@lists.sourceforge.net
Subject: Re: [Sisuite-devel] Cleanup for post-install dir in client's /tmp ?
99harmless_script is there as an example script to give users an idea of
how post-install scripts work. If we modify it to do something, it
would cease to be harmless. ;-)
Perhaps take a look at the code (/etc/init.d/functions probably) that
puts it there, and see if it makes sense to remove it at that point...
Thus spake Bernard Li ([EMAIL PROTECTED]):
Currently there is a post-install directory under /tmp in the resulting node
that was imaged by SystemImager - we should probably clean it up... I suggest
using the 99harmless_script?
Cheers,
Bernard
--
Brian Elliott Finley
Mobile: 630.631.6621
--
Brian Elliott Finley
Mobile: 630.631.6621
--
Brian Elliott Finley
Mobile: 630.631.6621
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Sisuite-devel mailing list
Sisuite-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sisuite-devel
