On Fri, Nov 30, 2018 at 11:48:38AM +0100, Justin Ossevoort wrote:
> Hello,
> 
> I suppose I could move it to the 'data' directory, but as
> 's6-notifyoncheck' by default searches for the 'check' script in the
> service directory itself, that doesn't feel right.
The s6 docs say ./data/check is thw default. We had some discussions
around the default location and decided that it was better to use data
thab to overload the main service dir more. If it's not searching data
by default, that's a bug.
> 
> And finally I somehow had the impression that the 'check' script was the
> official script for liveness checks, but I can't recollect where I got that
> impression from.
runit. The official method for readiness is to emit a line on the
notification fd. Ideally it is done via the program itself but if not,
s6-notifyoncheck provides a helpful shim since the alternative of
writing check logic into run scripts is a pain in the butt.
> 
> So I guess my question are:
> - Is 'check' script for liveness checks considered a feature/convention
> inside the s6 ecosphere?
If your service can't do it internaly, yes.
> - Should including it be considered for a feature request in s6-rc?
It should be included as part of the general payload set that gets
copied with data/
> 
> Regards,
> 
> Justin
Cheers!
-- 
Colin Booth

Reply via email to