Revision: 5455
          http://skim-app.svn.sourceforge.net/skim-app/?rev=5455&view=rev
Author:   hofman
Date:     2009-06-28 11:21:14 +0000 (Sun, 28 Jun 2009)

Log Message:
-----------
retain update check timer

Modified Paths:
--------------
    trunk/vendorsrc/andymatuschak/Sparkle/SUUpdater.m

Modified: trunk/vendorsrc/andymatuschak/Sparkle/SUUpdater.m
===================================================================
--- trunk/vendorsrc/andymatuschak/Sparkle/SUUpdater.m   2009-06-26 13:01:29 UTC 
(rev 5454)
+++ trunk/vendorsrc/andymatuschak/Sparkle/SUUpdater.m   2009-06-28 11:21:14 UTC 
(rev 5455)
@@ -151,6 +151,7 @@
        if (checkTimer)
        {
                [checkTimer invalidate];
+               [checkTimer release];
                checkTimer = nil;
        }
        if (![self automaticallyChecksForUpdates]) return;
@@ -168,7 +169,7 @@
                delayUntilCheck = (updateCheckInterval - intervalSinceCheck); 
// It hasn't been long enough.
        else
                delayUntilCheck = 0; // We're overdue! Run one now.
-       checkTimer = [NSTimer scheduledTimerWithTimeInterval:delayUntilCheck 
target:self selector:@selector(checkForUpdatesInBackground) userInfo:nil 
repeats:NO];
+       checkTimer = [[NSTimer scheduledTimerWithTimeInterval:delayUntilCheck 
target:self selector:@selector(checkForUpdatesInBackground) userInfo:nil 
repeats:NO] retain];
 }
 
 - (void)checkForUpdatesInBackground
@@ -189,7 +190,12 @@
 - (void)checkForUpdatesWithDriver:(SUUpdateDriver *)d
 {
        if ([self updateInProgress]) { return; }
-       if (checkTimer) { [checkTimer invalidate]; checkTimer = nil; }
+       if (checkTimer)
+       {
+               [checkTimer invalidate];
+               [checkTimer release];
+               checkTimer = nil;
+       }
                
        [self willChangeValueForKey:@"lastUpdateCheckDate"];
        [host setObject:[NSDate date] forUserDefaultsKey:SULastCheckTimeKey];
@@ -366,7 +372,11 @@
 {
        [self unregisterAsObserver];
        [host release];
-       if (checkTimer) { [checkTimer invalidate]; }
+       if (checkTimer)
+       {
+               [checkTimer invalidate];
+               [checkTimer release];
+       }
        [super dealloc];
 }
 


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to