Revision: 5456
          http://skim-app.svn.sourceforge.net/skim-app/?rev=5456&view=rev
Author:   hofman
Date:     2009-06-29 21:00:59 +0000 (Mon, 29 Jun 2009)

Log Message:
-----------
Don't pass an error handler for file manager methods, because this causes error 
leaks

Modified Paths:
--------------
    trunk/vendorsrc/andymatuschak/Sparkle/SUPlainInstallerInternals.m

Modified: trunk/vendorsrc/andymatuschak/Sparkle/SUPlainInstallerInternals.m
===================================================================
--- trunk/vendorsrc/andymatuschak/Sparkle/SUPlainInstallerInternals.m   
2009-06-28 11:21:14 UTC (rev 5455)
+++ trunk/vendorsrc/andymatuschak/Sparkle/SUPlainInstallerInternals.m   
2009-06-29 21:00:59 UTC (rev 5456)
@@ -235,13 +235,13 @@
 
        NSString *tmpPath = [self _temporaryCopyNameForPath:dst];
 
-       if (![[NSFileManager defaultManager] movePath:dst toPath:tmpPath 
handler:self])
+       if (![[NSFileManager defaultManager] movePath:dst toPath:tmpPath 
handler:nil])
        {
                if (error != NULL)
                        *error = [NSError errorWithDomain:SUSparkleErrorDomain 
code:SUFileCopyFailure userInfo:[NSDictionary dictionaryWithObject:[NSString 
stringWithFormat:@"Couldn't move %@ to %...@.", dst, tmpPath] 
forKey:NSLocalizedDescriptionKey]];
                return NO;                      
        }
-       if (![[NSFileManager defaultManager] copyPath:src toPath:dst 
handler:self])
+       if (![[NSFileManager defaultManager] copyPath:src toPath:dst 
handler:nil])
        {
                if (error != NULL)
                        *error = [NSError errorWithDomain:SUSparkleErrorDomain 
code:SUFileCopyFailure userInfo:[NSDictionary dictionaryWithObject:[NSString 
stringWithFormat:@"Couldn't copy %@ to %...@.", src, dst] 
forKey:NSLocalizedDescriptionKey]];


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to