Revision: 9517
          http://sourceforge.net/p/skim-app/code/9517
Author:   hofman
Date:     2017-12-02 22:01:11 +0000 (Sat, 02 Dec 2017)
Log Message:
-----------
fix leak of unarchiver in sparkle

Modified Paths:
--------------
    trunk/vendorsrc/andymatuschak/Sparkle/SUAutomaticUpdateDriver.m
    trunk/vendorsrc/andymatuschak/Sparkle/SUUIBasedUpdateDriver.m

Modified: trunk/vendorsrc/andymatuschak/Sparkle/SUAutomaticUpdateDriver.m
===================================================================
--- trunk/vendorsrc/andymatuschak/Sparkle/SUAutomaticUpdateDriver.m     
2017-12-01 10:35:28 UTC (rev 9516)
+++ trunk/vendorsrc/andymatuschak/Sparkle/SUAutomaticUpdateDriver.m     
2017-12-02 22:01:11 UTC (rev 9517)
@@ -15,6 +15,7 @@
 
 - (void)unarchiverDidFinish:(SUUnarchiver *)ua
 {
+    if (ua) { CFRelease(ua); }
        alert = [[SUAutomaticUpdateAlert alloc] initWithAppcastItem:updateItem 
host:host delegate:self];
        if ([NSApp isActive])
                [[alert window] makeKeyAndOrderFront:self];

Modified: trunk/vendorsrc/andymatuschak/Sparkle/SUUIBasedUpdateDriver.m
===================================================================
--- trunk/vendorsrc/andymatuschak/Sparkle/SUUIBasedUpdateDriver.m       
2017-12-01 10:35:28 UTC (rev 9516)
+++ trunk/vendorsrc/andymatuschak/Sparkle/SUUIBasedUpdateDriver.m       
2017-12-02 22:01:11 UTC (rev 9517)
@@ -132,6 +132,7 @@
 
 - (void)unarchiverDidFinish:(SUUnarchiver *)ua
 {
+    if (ua) { CFRelease(ua); }
        [statusController beginActionWithTitle:SULocalizedString(@"Ready to 
Install", nil) maxProgressValue:1 statusText:nil];
        [statusController setProgressValue:1]; // Fill the bar.
        [statusController setButtonEnabled:YES];

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to