Revision: 9518
http://sourceforge.net/p/skim-app/code/9518
Author: hofman
Date: 2017-12-03 21:33:57 +0000 (Sun, 03 Dec 2017)
Log Message:
-----------
fix leak of alert in updater
Modified Paths:
--------------
trunk/vendorsrc/andymatuschak/Sparkle/SUAutomaticUpdateDriver.m
trunk/vendorsrc/andymatuschak/Sparkle/SUBasicUpdateDriver.m
trunk/vendorsrc/andymatuschak/Sparkle/SUUIBasedUpdateDriver.m
trunk/vendorsrc/andymatuschak/Sparkle/SUUpdateDriver.m
Modified: trunk/vendorsrc/andymatuschak/Sparkle/SUAutomaticUpdateDriver.m
===================================================================
--- trunk/vendorsrc/andymatuschak/Sparkle/SUAutomaticUpdateDriver.m
2017-12-02 22:01:11 UTC (rev 9517)
+++ trunk/vendorsrc/andymatuschak/Sparkle/SUAutomaticUpdateDriver.m
2017-12-03 21:33:57 UTC (rev 9518)
@@ -15,7 +15,7 @@
- (void)unarchiverDidFinish:(SUUnarchiver *)ua
{
- if (ua) { CFRelease(ua); }
+ [super unarchiverDidFinish:ua];
alert = [[SUAutomaticUpdateAlert alloc] initWithAppcastItem:updateItem
host:host delegate:self];
if ([NSApp isActive])
[[alert window] makeKeyAndOrderFront:self];
@@ -31,6 +31,7 @@
- (void)automaticUpdateAlert:(SUAutomaticUpdateAlert *)aua
finishedWithChoice:(SUAutomaticInstallationChoice)choice;
{
+ [alert release]; alert = nil;
switch (choice)
{
case SUInstallNowChoice:
Modified: trunk/vendorsrc/andymatuschak/Sparkle/SUBasicUpdateDriver.m
===================================================================
--- trunk/vendorsrc/andymatuschak/Sparkle/SUBasicUpdateDriver.m 2017-12-02
22:01:11 UTC (rev 9517)
+++ trunk/vendorsrc/andymatuschak/Sparkle/SUBasicUpdateDriver.m 2017-12-03
21:33:57 UTC (rev 9518)
@@ -208,7 +208,6 @@
- (void)unarchiverDidFinish:(SUUnarchiver *)ua
{
if (ua) { CFRelease(ua); }
- [self installUpdate];
}
- (void)unarchiverDidFail:(SUUnarchiver *)ua
Modified: trunk/vendorsrc/andymatuschak/Sparkle/SUUIBasedUpdateDriver.m
===================================================================
--- trunk/vendorsrc/andymatuschak/Sparkle/SUUIBasedUpdateDriver.m
2017-12-02 22:01:11 UTC (rev 9517)
+++ trunk/vendorsrc/andymatuschak/Sparkle/SUUIBasedUpdateDriver.m
2017-12-03 21:33:57 UTC (rev 9518)
@@ -132,7 +132,7 @@
- (void)unarchiverDidFinish:(SUUnarchiver *)ua
{
- if (ua) { CFRelease(ua); }
+ [super unarchiverDidFinish:ua];
[statusController beginActionWithTitle:SULocalizedString(@"Ready to
Install", nil) maxProgressValue:1 statusText:nil];
[statusController setProgressValue:1]; // Fill the bar.
[statusController setButtonEnabled:YES];
Modified: trunk/vendorsrc/andymatuschak/Sparkle/SUUpdateDriver.m
===================================================================
--- trunk/vendorsrc/andymatuschak/Sparkle/SUUpdateDriver.m 2017-12-02
22:01:11 UTC (rev 9517)
+++ trunk/vendorsrc/andymatuschak/Sparkle/SUUpdateDriver.m 2017-12-03
21:33:57 UTC (rev 9518)
@@ -36,7 +36,7 @@
- (void)dealloc
{
- [host release];
+ [host release];
[appcastURL release];
[super dealloc];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
