Revision: 16629
http://sourceforge.net/p/skim-app/code/16629
Author: hofman
Date: 2026-10-07 21:33:37 +0000 (Wed, 07 Oct 2026)
Log Message:
-----------
don't override performKeyEquivalent: in pdfview, this has not been overridden
in PDFView since 10.12
Modified Paths:
--------------
trunk/SKBasePDFView.m
trunk/SKPDFView.m
Modified: trunk/SKBasePDFView.m
===================================================================
--- trunk/SKBasePDFView.m 2026-10-07 15:57:25 UTC (rev 16628)
+++ trunk/SKBasePDFView.m 2026-10-07 21:33:37 UTC (rev 16629)
@@ -252,9 +252,6 @@
// we don't want to steal the printDocument: action from the responder chain
- (void)printDocument:(id)sender{}
-// PDFView has duplicated key equivalents for Cmd-+/- as well as Opt-Cmd-+/-,
which is totoally unnecessary and harmful
-- (BOOL)performKeyEquivalent:(NSEvent *)theEvent { return NO; }
-
#pragma mark Bug fixes
- (void)setDocument:(PDFDocument *)document {
Modified: trunk/SKPDFView.m
===================================================================
--- trunk/SKPDFView.m 2026-10-07 15:57:25 UTC (rev 16628)
+++ trunk/SKPDFView.m 2026-10-07 21:33:37 UTC (rev 16629)
@@ -1654,17 +1654,17 @@
}
- (BOOL)performKeyEquivalent:(NSEvent *)theEvent {
- if ([self hasReadingBar] == NO)
- return NO;
- unichar eventChar = [theEvent firstCharacter];
- if (IS_UP_DOWN_ARROW(eventChar) == NO)
- return NO;
- NSEventModifierFlags modifiers = [theEvent deviceIndependentModifierFlags]
& ~NSEventModifierFlagNumericPad & ~NSEventModifierFlagFunction;
- if (modifiers == moveReadingBarModifiers) {
- [self doMoveReadingBarForKey:eventChar];
- return YES;
+ if ([self hasReadingBar]) {
+ unichar eventChar = [theEvent firstCharacter];
+ if (IS_UP_DOWN_ARROW(eventChar)) {
+ NSEventModifierFlags modifiers = [theEvent
deviceIndependentModifierFlags] & ~NSEventModifierFlagNumericPad &
~NSEventModifierFlagFunction;
+ if (modifiers == moveReadingBarModifiers) {
+ [self doMoveReadingBarForKey:eventChar];
+ return YES;
+ }
+ }
}
- return NO;
+ return [super performKeyEquivalent:theEvent];
}
- (void)performMarkupToolMode {
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
