Revision: 16630
          http://sourceforge.net/p/skim-app/code/16630
Author:   hofman
Date:     2026-10-07 21:38:32 +0000 (Wed, 07 Oct 2026)
Log Message:
-----------
only bother ssetting ivar when we are using it

Modified Paths:
--------------
    trunk/SKBasePDFView.m

Modified: trunk/SKBasePDFView.m
===================================================================
--- trunk/SKBasePDFView.m       2026-10-07 21:33:37 UTC (rev 16629)
+++ trunk/SKBasePDFView.m       2026-10-07 21:38:32 UTC (rev 16630)
@@ -462,13 +462,15 @@
 }
 
 - (void)keyDown:(NSEvent *)event {
-    unichar ch = [event firstCharacter];
-    if (ch == NSPageDownFunctionKey || ch == NSDownArrowFunctionKey)
-        keyDirection = 1;
-    else if (ch == NSPageUpFunctionKey || ch == NSUpArrowFunctionKey)
-        keyDirection = -1;
-    else if (ch == SKSpaceCharacter)
-        keyDirection = ([event modifierFlags] & NSEventModifierFlagShift) ? -1 
: 1;
+    if ([self displayDirection]) {
+        unichar ch = [event firstCharacter];
+        if (ch == NSPageDownFunctionKey || ch == NSDownArrowFunctionKey)
+            keyDirection = 1;
+        else if (ch == NSPageUpFunctionKey || ch == NSUpArrowFunctionKey)
+            keyDirection = -1;
+        else if (ch == SKSpaceCharacter)
+            keyDirection = ([event modifierFlags] & NSEventModifierFlagShift) 
? -1 : 1;
+    }
     [super keyDown:event];
     keyDirection = 0;
 }

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to