Hi
I�m developing a client application based on webdav, using Slide as the
server, which is accessing large collections (in the thousands), and I'm
running into problems with the time Slide takes to execute a PROPFIND on
large collections .
One thing I noticed in the PROPFIND method is that ~30% of the total
method time is taken in the call to <getLabeledResourceUri> in
<VersioningHelper>, since the helper class retrieves all the node
descriptors (including their properties) from the store - so in fact the
revisions are retrieved from the store 2 or 3 times rather than once.
Anyway, the following patch on <VersioningHelper> improves the response
time of PROPFIND by 20-30%. The assumption is that the URI of the latest
version of a resource is the URI itself, in all cases (I think this is
true, from the code, and it works).
* $Header:
/home/cvspublic/jakarta-slide/src/webdav/server/org/apache/slide/webdav/
util/VersioningHelper.java,v 1.91 2003/10/16 10:51:24 pnever Exp $
* $Revision: 1.91 $
Original (lines 1933-1935)
public static String getLabeledResourceUri(NamespaceAccessToken
nsaToken, SlideToken sToken, Content content, String resourcePath,
String label) throws SlideException, LabeledRevisionNotFoundException {
NodeRevisionDescriptors revisionDescriptors =
content.retrieve( sToken, resourcePath );
Patched (1933-1938)
public static String getLabeledResourceUri(NamespaceAccessToken
nsaToken, SlideToken sToken, Content content, String resourcePath,
String label) throws SlideException, LabeledRevisionNotFoundException {
if (label == null){
return resourcePath;
}
NodeRevisionDescriptors revisionDescriptors =
content.retrieve( sToken, resourcePath );
Questions: is it worthwhile caring about optimisation yet, and is this
the proper forum for such a small patch, or should I address a Slide
developer directly?
Nick Reddel
mailto:[EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
