DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=30442>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=30442 How to make slide faster - submission ------- Additional Comments From [EMAIL PROTECTED] 2004-08-03 12:49 ------- First of all thanks for the contribution :) My comments after review: (1) For the future, please contribute patch files rather than complete ones. This makes life much easier. You can create them e.g. with cvs diff -uw fileName (2) In NodeRevisionDescriptor you need to take into account the namespace as well. E.g. updatedProps.add(property.getName()); should rather be updatedProps.add(getNamespacedPropertyName(property.getNamespace(), property.getName()); (3) In StandardRDBMSAdapter fields updates and updatedBindings for sure can not be global variables. The whole adapter will be used by multiple concurrent threads. Why aren't local ones sufficient in the first place? (4) In StandardRDBMSAdapter method createRevisionDescriptor: If the descriptor is created can there by any updated properties? (5) In StandardRDBMSAdapter method removeRevisionDescriptor and clearBinding: Could you explain? Why not delete all properties / bindings? Why rely on that global variable? --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
