DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=30442>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30442

How to make slide faster - submission





------- Additional Comments From [EMAIL PROTECTED]  2004-08-03 21:57 -------
1) Ok, I will attach the new diffs.  
2)  To do it the way you suggest (updatedProps.add(getNamespacedPropertyName
(property.getNamespace(),property.getName());)complicates things a little 
because the getNamespacedProperyName() method combines the property name and 
namespace into one string and you can't separate them back out. This causes a 
problem because the database stores them in separate fields.  I was able to 
use the properties table to retrieve the name and namespace, but I'm not sure 
this is the most efficient way to do this.    

3) Local variables didn't seem to be sufficient because 
RemoveRevisionDescriptors doesn't have access to the revisiondescriptor to get 
the list of updated properties.  However if we use the solution Jim mentioned, 
to combine delete and create inside store then it could be a local variable. 
5) I was deleting just some of the properties/bindings because if you delete 
all properties then you must reinsert all of the properties or you lose the 
properties that you don't reinsert.  I did this because if an object has 100 
children and you wish to add/update one child, it is much more efficient to 
delete that one binding (if it exists) and reinsert it than to delete and 
reinsert all 100.  But if we combine create and remove in store then we 
shouldn't need to be selective about which we delete in 
removerevisiondescriptor.



I also caught a small problem in ObjectNode in the constructor where bindings 
were being passed in but I wasn't placing them in the updated list.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to