Hi,
Taking this discussion to the list...
Looking at this report, there is one method - objectId(Object) - which
is not clearly destined at creating a LogFactory implementation.
So my question with respect to JCL is: Do these bundles really require
1.1.1 as per
Import-Package: org.apache.commons.logging;version=1.1.1
Or do such bundles need the objectId method ?
If it is for the first reason, we may "hack" this by just exporting the
o.a.commons.logging package as being of version 1.1.1. If for the second
reason, we can probably not do much about it.
WDYT ?
Regards
Felix
Am Freitag, den 23.05.2008, 01:53 -0700 schrieb Niklas Gustavsson
(JIRA):
> [
> https://issues.apache.org/jira/browse/SLING-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599303#action_12599303
> ]
>
> Niklas Gustavsson commented on SLING-471:
> -----------------------------------------
>
> A CLIRR diff between 1.0.4 and 1.1.1 does show some changes to LogFactory:
> INFO: 6000: org.apache.commons.logging.LogFactory: Added public field
> DIAGNOSTICS_DEST_PROPERTY
> INFO: 6000: org.apache.commons.logging.LogFactory: Added public field
> HASHTABLE_IMPLEMENTATION_PROPERTY
> INFO: 6000: org.apache.commons.logging.LogFactory: Added public field
> PRIORITY_KEY
> INFO: 6000: org.apache.commons.logging.LogFactory: Added public field TCCL_KEY
> INFO: 6000: org.apache.commons.logging.LogFactory: Added protected field
> nullClassLoaderFactory
> INFO: 7011: org.apache.commons.logging.LogFactory: Method 'protected
> java.lang.Object createFactory(java.lang.String, java.lang.ClassLoader)' has
> been added
> INFO: 7011: org.apache.commons.logging.LogFactory: Method 'protected
> java.lang.ClassLoader directGetContextClassLoader()' has been added
> INFO: 7011: org.apache.commons.logging.LogFactory: Method 'protected
> java.lang.ClassLoader getClassLoader(java.lang.Class)' has been added
> INFO: 7011: org.apache.commons.logging.LogFactory: Method 'protected boolean
> isDiagnosticsEnabled()' has been added
> INFO: 7011: org.apache.commons.logging.LogFactory: Method 'protected void
> logRawDiagnostic(java.lang.String)' has been added
> INFO: 7011: org.apache.commons.logging.LogFactory: Method 'protected
> org.apache.commons.logging.LogFactory newFactory(java.lang.String,
> java.lang.ClassLoader, java.lang.ClassLoader)' has been added
> INFO: 7011: org.apache.commons.logging.LogFactory: Method 'public
> java.lang.String objectId(java.lang.Object)' has been added
>
> If Sling should declare an export of version 1.1.1, these changes would need
> to be available. Any change of SLF4J implementing these (this might not the
> best place for that discussion of course :-)?
>
> > LogService to implement JCL 1.1.1
> > ---------------------------------
> >
> > Key: SLING-471
> > URL: https://issues.apache.org/jira/browse/SLING-471
> > Project: Sling
> > Issue Type: Improvement
> > Components: Commons Log
> > Affects Versions: 2.0.0
> > Reporter: Niklas Gustavsson
> >
> > Some bundles have dependencies to org.apache.commons-logging 1.1.1 while
> > LogService only provides 1.0.4. Could LogService provide support for 1.1.1?
> > SLF4J which is currently used only provides support for 1.0.4 so a
> > different solution would be required.
>
