On Mon, Jun 16, 2008 at 12:57 PM, Jukka Zitting <[EMAIL PROTECTED]> wrote: > HI, > > On Mon, Jun 16, 2008 at 12:22 PM, Carsten Ziegeler <[EMAIL PROTECTED]> wrote: >> So I would like to hear a final comment from Jukka and Roy before cutting a >> release. > > Looks pretty good. Some comments: > > a) Some LICENSE files refer to feedparser tests, but I couldn't find > them anywhere. Is the reference needed? > > b) Should we include "Copyright (c) 2002 JSON.org" in trunk/NOTICE?
I think we have to if we have json code in trunk (not sure that this is still the case?). > c) AFAIUI the year in "Copyright ... The Apache Software Foundation" > statements should be "2008", not "2007-2008". See related discussion > on [EMAIL PROTECTED] Not a blocker IMO. > > d) Many of the generated bundles don't have complete NOTICE files (for > example commons.log doesn't mention SLF4J even though SLF4J classes > are included), but I wouldn't treat that as a blocker as the bundles > are secondary release artifacts and the required information is still > available in the LICENSE.* files. Well, I think that is not optimal. If the bundle artifact contains code under a license that mandates a NOTICE then it should be in the NOTICE file of the binary. > e) The LICENSE files don't have references to the LICENSE.* files. Roy > says they should. If we place references in LICENSE, I think we could > just as well put the entire license texts there. I think that makes sense - the LICENSE.* files are somewhat none standard and probably not really supported by downstream tools. regards, Karl > BR, > > Jukka Zitting > -- Karl Pauls [EMAIL PROTECTED]
