On Mon, Jun 16, 2008 at 1:59 PM, Carsten Ziegeler <[EMAIL PROTECTED]> wrote: > Jukka Zitting wrote: >> >> HI, >> >> On Mon, Jun 16, 2008 at 12:22 PM, Carsten Ziegeler <[EMAIL PROTECTED]> >> wrote: >>> >>> So I would like to hear a final comment from Jukka and Roy before cutting >>> a >>> release. >> >> Looks pretty good. Some comments: >> >> a) Some LICENSE files refer to feedparser tests, but I couldn't find >> them anywhere. Is the reference needed? > > No, its a copy-paste error :( > >> >> b) Should we include "Copyright (c) 2002 JSON.org" in trunk/NOTICE? >> > Hmm, Roy says we don't have to (at least this is what I understood during > the whole discussion) - but lets add it.
I think we still need to keep the attribution as far as I understand his last mail... >> c) AFAIUI the year in "Copyright ... The Apache Software Foundation" >> statements should be "2008", not "2007-2008". See related discussion >> on [EMAIL PROTECTED] Not a blocker IMO. > > Yes, this is another one of those discussions :) I'll change all of them to > 2008. > >> >> d) Many of the generated bundles don't have complete NOTICE files (for >> example commons.log doesn't mention SLF4J even though SLF4J classes >> are included), but I wouldn't treat that as a blocker as the bundles >> are secondary release artifacts and the required information is still >> available in the LICENSE.* files. > > Great. Again these are things where Roy said we don't need them. Again, I think for the binaries we do need the attribution and the LICENSE files because we don't embed the complete jar's. We only include some of the code -- hence, the original NOTICE and LICENSE files are not included in the resulting artifact and needs to be added by us. >> >> e) The LICENSE files don't have references to the LICENSE.* files. Roy >> says they should. If we place references in LICENSE, I think we could >> just as well put the entire license texts there. > > I would go with a reference. Including the LICENSE.* files and adding references in the LICENSE file feels a bit strange - it seems easier to just put the entire license texts there... regards, Karl > Carsten > -- > Carsten Ziegeler > [EMAIL PROTECTED] > -- Karl Pauls [EMAIL PROTECTED]
