[
https://issues.apache.org/jira/browse/SLING-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669581#action_12669581
]
Bertrand Delacretaz commented on SLING-549:
-------------------------------------------
Thanks Felix for taking care of this.
> Could you please verify that everything works alright and then close this
> issue ?
Michael, while you're at it, could you add an integration test for this module
in the launchpad/testing module?
A smoke test similar to [1] would be good already, just something that proves
that the Scala engine is basically working. This would also require adding the
required sling/scala modules to launchpad/testing/pom.xml
[1]
launchpad/testing/src/test/resources/integration-test/rendering-test.jsp
and
launchpad/testing/src/test/java/org/apache/sling/launchpad/webapp/integrationtest/JspScriptingTest.java
> Scala script engine
> -------------------
>
> Key: SLING-549
> URL: https://issues.apache.org/jira/browse/SLING-549
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Bertrand Delacretaz
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: SLING-549-2.patch, SLING-549-3.patch, SLING-549.patch
>
>
> As the code at [1] demonstrates, the scala interpreter rebuilds its own
> classpath from the current JVM classpath and user-supplied additions.
> We should find a way for it to use the current classloader instead.
> Note that the almost same test [2] works when run with "mvn test" without
> setting the classpath explicitly, probably because in this case the JVM
> classpath includes the scala jars.
> [1]
> http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/main/java/org/apache/sling/scripting/scala/minbundle/ScalaCompileServlet.java
> [2]
> http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/test/java/org/apache/sling/scripting/scala/minbundle/ScalaCompilerTest.java?r=38
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
