[
https://issues.apache.org/jira/browse/SLING-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger resolved SLING-549.
-------------------------------------
Resolution: Fixed
Thanks for supplying (and maintaining) the patch. I have applied it in Rev.
739973 with some modifications:
* Removed the META-INF/services/javax.script:ScriptEngineFactory file since
the ScriptEngineFactory
is registered as an OSGi service
* Fixed the README.txt, LICENSE, NOTICE and DISCLAIMER files
* Set the version to 0.9.0-incubator-SNAPSHOT, assuming an initial 1.0.0
version
* Fixed dependencies
* Fixed bundle generation to not require compile scope dependencies
AFAICT this makes a usable OSGi bundle, but since I don't know any Scala, I
could not really verify.
Could you please verify that everything works alright and then close this issue
? Thanks.
> Scala script engine
> -------------------
>
> Key: SLING-549
> URL: https://issues.apache.org/jira/browse/SLING-549
> Project: Sling
> Issue Type: Bug
> Components: Scripting
> Reporter: Bertrand Delacretaz
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: SLING-549-2.patch, SLING-549-3.patch, SLING-549.patch
>
>
> As the code at [1] demonstrates, the scala interpreter rebuilds its own
> classpath from the current JVM classpath and user-supplied additions.
> We should find a way for it to use the current classloader instead.
> Note that the almost same test [2] works when run with "mvn test" without
> setting the classpath explicitly, probably because in this case the JVM
> classpath includes the scala jars.
> [1]
> http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/main/java/org/apache/sling/scripting/scala/minbundle/ScalaCompileServlet.java
> [2]
> http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/test/java/org/apache/sling/scripting/scala/minbundle/ScalaCompilerTest.java?r=38
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
