Hi Junajo, Thanks for applying the accessmanager bundle. I took a look at the unit test failures and I think I see what the issue is. When I wrote those tests I had the latest patch from SLING-875 (see usermanager_as_servlets.zip) already applied. So the test code that creates the users and groups used to test updating the ACL was relying on the changes from the usermanager_as_servlets patch.
Can you (or someone else) review the SLING-875 patch and apply those changes along with the accessmanager integration tests from SLING-879? I think the SLING-875 patch also fixes SLING-891 so we could probably resolve those 3 issues at the same time... Regards, -Eric ** 2009/3/18 Juan José Vázquez Delgado <[email protected]> > Hi Eric, > > > Yes, it seemed to be working for me. I was using that method in the > patch I > > submitted for SLING-879 > > I have added the jackrabbit-accessmanager stuff into trunk (rev. > 755539). I have run some testing and everything seems to be ok. Cool > stuff, thank you!. > > Although, I haven´t applied the integration tests patch because they > are failing [1]. Please, tell me if you see the reason at first sight. > > BR, > > Juanjo. > > [1] > > > ------------------------------------------------------------------------------- > Test set: > org.apache.sling.launchpad.webapp.integrationtest.accessManager.ModifyAceTest > > ------------------------------------------------------------------------------- > Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 23.538 > sec <<< FAILURE! > > testModifyAceForUser(org.apache.sling.launchpad.webapp.integrationtest.accessManager.ModifyAceTest) > Time elapsed: 23.514 sec <<< FAILURE! > junit.framework.AssertionFailedError: expected:<200> but was:<500> > at junit.framework.Assert.fail(Assert.java:47) > at junit.framework.Assert.failNotEquals(Assert.java:277) > at junit.framework.Assert.assertEquals(Assert.java:64) > at junit.framework.Assert.assertEquals(Assert.java:195) > at junit.framework.Assert.assertEquals(Assert.java:201) > at > org.apache.sling.launchpad.webapp.integrationtest.accessManager.AbstractAccessManagerTest.assertAuthenticatedPostStatus(AbstractAccessManagerTest.java:65) > at > org.apache.sling.launchpad.webapp.integrationtest.accessManager.ModifyAceTest.testModifyAceForUser(ModifyAceTest.java:81) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:585) > at junit.framework.TestCase.runTest(TestCase.java:168) > at junit.framework.TestCase.runBare(TestCase.java:134) > at junit.framework.TestResult$1.protect(TestResult.java:110) > at junit.framework.TestResult.runProtected(TestResult.java:128) > at junit.framework.TestResult.run(TestResult.java:113) > at junit.framework.TestCase.run(TestCase.java:124) > at junit.framework.TestSuite.runTest(TestSuite.java:232) > at junit.framework.TestSuite.run(TestSuite.java:227) > at > org.junit.internal.runners.OldTestClassRunner.run(OldTestClassRunner.java:76) > at > org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) > at > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) > at > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) > at org.apache.maven.surefire.Surefire.run(Surefire.java:177) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:585) > at > org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345) > at > org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009) > > > testModifyAceForGroup(org.apache.sling.launchpad.webapp.integrationtest.accessManager.ModifyAceTest) > Time elapsed: 0.016 sec <<< FAILURE! > junit.framework.AssertionFailedError: expected:<200> but was:<201> > at junit.framework.Assert.fail(Assert.java:47) > at junit.framework.Assert.failNotEquals(Assert.java:277) > at junit.framework.Assert.assertEquals(Assert.java:64) > at junit.framework.Assert.assertEquals(Assert.java:195) > at junit.framework.Assert.assertEquals(Assert.java:201) > at > org.apache.sling.launchpad.webapp.integrationtest.accessManager.AbstractAccessManagerTest.assertAuthenticatedPostStatus(AbstractAccessManagerTest.java:65) > at > org.apache.sling.launchpad.webapp.integrationtest.accessManager.AbstractAccessManagerTest.createTestGroup(AbstractAccessManagerTest.java:178) > at > org.apache.sling.launchpad.webapp.integrationtest.accessManager.ModifyAceTest.testModifyAceForGroup(ModifyAceTest.java:106) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:585) > at junit.framework.TestCase.runTest(TestCase.java:168) > at junit.framework.TestCase.runBare(TestCase.java:134) > at junit.framework.TestResult$1.protect(TestResult.java:110) > at junit.framework.TestResult.runProtected(TestResult.java:128) > at junit.framework.TestResult.run(TestResult.java:113) > at junit.framework.TestCase.run(TestCase.java:124) > at junit.framework.TestSuite.runTest(TestSuite.java:232) > at junit.framework.TestSuite.run(TestSuite.java:227) > at > org.junit.internal.runners.OldTestClassRunner.run(OldTestClassRunner.java:76) > at > org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) > at > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) > at > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) > at org.apache.maven.surefire.Surefire.run(Surefire.java:177) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:585) > at > org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345) > at > org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009) > > > ------------------------------------------------------------------------------- > Test set: > org.apache.sling.launchpad.webapp.integrationtest.accessManager.RemoveAcesTest > > ------------------------------------------------------------------------------- > Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: > 311.257 sec <<< FAILURE! > > testRemoveAce(org.apache.sling.launchpad.webapp.integrationtest.accessManager.RemoveAcesTest) > Time elapsed: 20.381 sec <<< FAILURE! > junit.framework.AssertionFailedError: expected:<200> but was:<201> > at junit.framework.Assert.fail(Assert.java:47) > at junit.framework.Assert.failNotEquals(Assert.java:277) > at junit.framework.Assert.assertEquals(Assert.java:64) > at junit.framework.Assert.assertEquals(Assert.java:195) > at junit.framework.Assert.assertEquals(Assert.java:201) > at > org.apache.sling.commons.testing.integration.HttpTestBase.assertPostStatus(HttpTestBase.java:276) > at > org.apache.sling.launchpad.webapp.integrationtest.accessManager.AbstractAccessManagerTest.createTestUser(AbstractAccessManagerTest.java:164) > at > org.apache.sling.launchpad.webapp.integrationtest.accessManager.RemoveAcesTest.createFolderWithAces(RemoveAcesTest.java:69) > at > org.apache.sling.launchpad.webapp.integrationtest.accessManager.RemoveAcesTest.testRemoveAce(RemoveAcesTest.java:130) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:585) > at junit.framework.TestCase.runTest(TestCase.java:168) > at junit.framework.TestCase.runBare(TestCase.java:134) > at junit.framework.TestResult$1.protect(TestResult.java:110) > at junit.framework.TestResult.runProtected(TestResult.java:128) > at junit.framework.TestResult.run(TestResult.java:113) > at junit.framework.TestCase.run(TestCase.java:124) > at junit.framework.TestSuite.runTest(TestSuite.java:232) > at junit.framework.TestSuite.run(TestSuite.java:227) > at > org.junit.internal.runners.OldTestClassRunner.run(OldTestClassRunner.java:76) > at > org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) > at > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) > at > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) > at org.apache.maven.surefire.Surefire.run(Surefire.java:177) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:585) > at > org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345) > at > org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009) > > > testRemoveAces(org.apache.sling.launchpad.webapp.integrationtest.accessManager.RemoveAcesTest) > Time elapsed: 284.982 sec <<< FAILURE! > junit.framework.AssertionFailedError: expected:<200> but was:<500> > at junit.framework.Assert.fail(Assert.java:47) > at junit.framework.Assert.failNotEquals(Assert.java:277) > at junit.framework.Assert.assertEquals(Assert.java:64) > at junit.framework.Assert.assertEquals(Assert.java:195) > at junit.framework.Assert.assertEquals(Assert.java:201) > at > org.apache.sling.launchpad.webapp.integrationtest.accessManager.AbstractAccessManagerTest.assertAuthenticatedPostStatus(AbstractAccessManagerTest.java:65) > at > org.apache.sling.launchpad.webapp.integrationtest.accessManager.RemoveAcesTest.createFolderWithAces(RemoveAcesTest.java:80) > at > org.apache.sling.launchpad.webapp.integrationtest.accessManager.RemoveAcesTest.testRemoveAces(RemoveAcesTest.java:151) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:585) > at junit.framework.TestCase.runTest(TestCase.java:168) > at junit.framework.TestCase.runBare(TestCase.java:134) > at junit.framework.TestResult$1.protect(TestResult.java:110) > at junit.framework.TestResult.runProtected(TestResult.java:128) > at junit.framework.TestResult.run(TestResult.java:113) > at junit.framework.TestCase.run(TestCase.java:124) > at junit.framework.TestSuite.runTest(TestSuite.java:232) > at junit.framework.TestSuite.run(TestSuite.java:227) > at > org.junit.internal.runners.OldTestClassRunner.run(OldTestClassRunner.java:76) > at > org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) > at > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) > at > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) > at org.apache.maven.surefire.Surefire.run(Surefire.java:177) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:585) > at > org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345) > at > org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009) >
