Hi Eric,

> Thanks for applying the accessmanager bundle.

You´re welcome.

> I took a look at the unit
> test failures and I think I see what the issue is.  When I wrote those tests
> I had the latest patch from SLING-875 (see usermanager_as_servlets.zip)
> already applied.  So the test code that creates the users and groups used to
> test updating the ACL was relying on the changes from the
> usermanager_as_servlets patch.
>
> Can you (or someone else) review the SLING-875 patch and apply those changes
> along with the accessmanager integration tests from SLING-879?
>
> I think the SLING-875 patch also fixes SLING-891 so we could probably
> resolve those 3 issues at the same time...

I have applied in my environment "usermanager_as_servlet.zip" found in
SLING-875 and the integration tests fail [1]. Is this working for
you?.

BR,

Juanjo.

[1]

Results :

Failed tests:
  
testUpdateGroup(org.apache.sling.launchpad.webapp.integrationtest.userManager.UpdateGroupTest)
  
testUpdateGroupMembers(org.apache.sling.launchpad.webapp.integrationtest.userManager.UpdateGroupTest)
  
testUpdateUser(org.apache.sling.launchpad.webapp.integrationtest.userManager.UpdateUserTest)
  
testChangeUserPassword(org.apache.sling.launchpad.webapp.integrationtest.userManager.UpdateUserTest)
  
testChangeUserPasswordWrongOldPwd(org.apache.sling.launchpad.webapp.integrationtest.userManager.UpdateUserTest)
  
testChangeUserPasswordWrongConfirmPwd(org.apache.sling.launchpad.webapp.integrationtest.userManager.UpdateUserTest)
  
testCreateUser(org.apache.sling.launchpad.webapp.integrationtest.userManager.CreateUserTest)
  
testCreateUserMissingUserId(org.apache.sling.launchpad.webapp.integrationtest.userManager.CreateUserTest)
  
testCreateUserMissingPwd(org.apache.sling.launchpad.webapp.integrationtest.userManager.CreateUserTest)
  
testCreateUserWrongConfirmPwd(org.apache.sling.launchpad.webapp.integrationtest.userManager.CreateUserTest)
  
testCreateUserUserAlreadyExists(org.apache.sling.launchpad.webapp.integrationtest.userManager.CreateUserTest)
  
testCreateUserWithExtraProperties(org.apache.sling.launchpad.webapp.integrationtest.userManager.CreateUserTest)
  
testCreateGroup(org.apache.sling.launchpad.webapp.integrationtest.userManager.CreateGroupTest)
  
testCreateGroupMissingGroupId(org.apache.sling.launchpad.webapp.integrationtest.userManager.CreateGroupTest)
  
testCreateGroupAlreadyExists(org.apache.sling.launchpad.webapp.integrationtest.userManager.CreateGroupTest)
  
testCreateGroupWithExtraProperties(org.apache.sling.launchpad.webapp.integrationtest.userManager.CreateGroupTest)
  
testRemoveUser(org.apache.sling.launchpad.webapp.integrationtest.userManager.RemoveAuthorizablesTest)
  
testRemoveGroup(org.apache.sling.launchpad.webapp.integrationtest.userManager.RemoveAuthorizablesTest)
  
testRemoveAuthorizables(org.apache.sling.launchpad.webapp.integrationtest.userManager.RemoveAuthorizablesTest)

Tests run: 235, Failures: 19, Errors: 0, Skipped: 0

Reply via email to