On 1/6/17 0:28 , Gernot Straßer wrote: > This is regarding ./proto/lib/svc/method/fs-local > > I was playing around with zfs crypto when I figured that script will fail if > there is an encrypted dataset waiting for passphrase input. > > In line 90 it does a zfs mount -va and fails hard if there is an error, > which causes all dependent services to fail . This includes sshd which > renders the system unaccessible. > > My proposal would be to skip checking for mount errors, but there might be > reasons I am not aware of.
Hi Gernot, I think there's a bit of a tension in there, which it's hard to have a good answer to today. Mainly, how do we know if the dataset in question that we couldn't mount is required for SmartOS to function and operate versus not. We may want to consider how that interacts with sshd, but then there are issues with host keys changing, etc. if you can't actually mount those datasets. I think we're going to have to rethink a lot of this when ZFS cyrpto does actually land, but there are a lot of open questions in terms of what should the interfaces be and how should it work with encryption. If those datasets aren't required for SmartOS to function, that's one thing, but if they are, or correspond to a VM dataset that the zones service wants to start, there are some more questions. At this point, I think we probably need to more generally rethink this before we just make it drive on. Robert ------------------------------------------- smartos-discuss Archives: https://www.listbox.com/member/archive/184463/=now RSS Feed: https://www.listbox.com/member/archive/rss/184463/25769125-55cfbc00 Modify Your Subscription: https://www.listbox.com/member/?member_id=25769125&id_secret=25769125-7688e9fb Powered by Listbox: http://www.listbox.com
